Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor index by generics #462

Merged
merged 6 commits into from
Sep 6, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Sep 5, 2023

Related: #403 (comment)

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #462 (2449e75) into master (46226a2) will increase coverage by 0.37%.
The diff coverage is 88.07%.

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   72.61%   72.99%   +0.37%     
==========================================
  Files          31       31              
  Lines        4189     4184       -5     
==========================================
+ Hits         3042     3054      +12     
+ Misses        881      865      -16     
+ Partials      266      265       -1     
Files Changed Coverage Δ
db.go 66.90% <66.66%> (-0.51%) ⬇️
tx_zset.go 48.69% <73.33%> (ø)
merge.go 70.17% <80.00%> (ø)
tx_bucket.go 83.87% <86.66%> (+15.75%) ⬆️
tx_set.go 63.89% <92.30%> (ø)
index.go 87.50% <92.85%> (+19.75%) ⬆️
iterator.go 69.69% <100.00%> (ø)
tx.go 80.18% <100.00%> (-0.14%) ⬇️
tx_btree.go 72.65% <100.00%> (ø)
tx_list.go 72.15% <100.00%> (ø)

@G-XD
Copy link
Contributor Author

G-XD commented Sep 5, 2023

Raw Output:
index.go:57:25: func (*defaultOp[T]).rangeIdx is unused (unused)
func (op *defaultOp[T]) rangeIdx(f func(elem *T)) {

db.go中的checkListExpired()有调用到此函数,这个问题怎么解决呢?

@bigboss2063
Copy link
Member

Raw Output:
index.go:57:25: func (*defaultOp[T]).rangeIdx is unused (unused)
func (op *defaultOp[T]) rangeIdx(f func(elem *T)) {

db.go中的checkListExpired()有调用到此函数,这个问题怎么解决呢?

可能是由于 checkListExpired 这个方法没有使用到导致它检测出现的问题

@bigboss2063
Copy link
Member

可以试一下给checkListExpired加个测试用例看看

@elliotchenzichang
Copy link
Member

Amizing!

@bigboss2063
Copy link
Member

LGTM!

@bigboss2063 bigboss2063 merged commit 8f8d8de into nutsdb:master Sep 6, 2023
6 checks passed
@G-XD G-XD deleted the refactor_index2 branch September 6, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants