Make test more stable by using JSONAssert equals #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed but it looks like it is due to flakyness in HttpTest itself, which is not related to this change |
|
thank you very much ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in
test/org/nutz/json/JsonTest.javacompares toJson results with several hard-coded strings.However, the
toJSONfunction depends ongetDeclaredFieldwhich does not guarantee any specific order, thus resulting a different serialized json string. So tests may fail or pass without any changes made to the source code and cannot serve as good regression tests.This PR proposes to use JSONAssert and change test assertions to check JSON results in a safer way.