AICORE-317: simplifying statistics to get terms and cardinality #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View issue in JIRA: AICORE-317: Fix statistics for getting terms and card |
PedroCardoso
approved these changes
Jun 23, 2020
| @@ -315,22 +300,25 @@ protected Long getOverallStats(List<PropertyType> featuresWithType, List<Statist | |||
| case TEXT_TYPE: | |||
| // TODO assuming that text is a property ! could be a blob | |||
| qb.addAggregate(makeAggregate(AGG_MISSING, propName, EMPTY_PROPS)); | |||
| qb.addAggregate(makeAggregate(AGG_TYPE_TERMS, propName, TERM_PROPS)); | |||
There was a problem hiding this comment.
We do not need terms stats for Text fields.
There was a problem hiding this comment.
actually we do. If you take a look at where I removed them, we had it before. And yes - it's a UI case. But it's still a case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.