AICORE-22: Google Vision #267
Conversation
|
View issue in JIRA: AICORE-22: Google Vision Enrichments Priority |
|
⭐ PR built and available in a preview environment nuxeo-nuxeo-ai-pr-267 here |
andreinechaev
force-pushed
the
feature-AICORE-22-google-vision
branch
3 times, most recently
from
9ab09e3
to
81a3fc0
Compare
andreinechaev
force-pushed
the
feature-AICORE-22-google-vision
branch
from
81a3fc0
to
bc0cd66
Compare
andreinechaev
force-pushed
the
feature-AICORE-22-google-vision
branch
from
3346180
to
223160c
Compare
|
⭐ PR built and available in a preview environment nuxeo-nuxeo-ai-pr-267 here |
1 similar comment
|
⭐ PR built and available in a preview environment nuxeo-nuxeo-ai-pr-267 here |
| if (vertices.size() != 4) { | ||
| return new AIMetadata.Box(0, 0, 0, 0); | ||
| } |
There was a problem hiding this comment.
Maybe this is not exactly what we want.
I would go for the smallest box we could do to fit the complete polygon. Maybe this is too much for the current task, but create a ticket for it.
There was a problem hiding this comment.
okay. I think it makes sense. thanks
There was a problem hiding this comment.
actually, as a second thought. If we don't have coordinates and those boxes are coming from multi object detection they will end up in one corner which doesn't make sense. Second, this case should never happen, I just decided that it's better than throwing an exception.
| /** | ||
| * Marker interface for Enrichments with bounding box available | ||
| */ | ||
| public interface Polygonal { |
There was a problem hiding this comment.
Opening a can of worms ... but not sure why, but I don't like the name. It is not so much about polygon, maybe polygonToBox ! anyway, ignore this if you want :)
There was a problem hiding this comment.
We shouldn't use transitive forms in naming :) A method inside may be named toBox or toCircle, the interface name should describe the object
|
+1 |
|
⭐ PR built and available in a preview environment nuxeo-nuxeo-ai-pr-267 here |
No description provided.