Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AICORE-376 pkgVersion #268

Merged
merged 1 commit into from Oct 22, 2020
Merged

fix AICORE-376 pkgVersion #268

merged 1 commit into from Oct 22, 2020

Conversation

jcarsique
Copy link
Contributor

Enforce fixed downstream package version to help circumvent NXP-29794

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: AICORE-376: Fix version dependency on our addons

tiagocardoso
tiagocardoso approved these changes Oct 22, 2020
View reviewed changes
Copy link

@tiagocardoso tiagocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it needed the version var to be with that syntax (double).
I don't know, but I thrust you ;)

@nuxeo-ai-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-ai-pr-268 here

@jcarsique
Copy link
Contributor Author

Looks like it needed the version var to be with that syntax (double).

@tiagocardoso the pattern is <package name>:<min version>:<max version>
While it's recommended to only set the min version in order to allow minor upgrades, the above strict requirement will partly prevent NXP-29794 from introducing an unwanted greater snapshot version (that should normally be excluded).

@jcarsique jcarsique merged commit dd9dc31 into sprint-3a-10.10 Oct 22, 2020
@jcarsique jcarsique deleted the fix-AICORE-376-pkgVersion branch October 22, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagocardoso tiagocardoso tiagocardoso approved these changes

@PedroCardoso PedroCardoso Awaiting requested review from PedroCardoso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jcarsique @nuxeojenkins @nuxeo-ai-jx-bot @tiagocardoso