AICORE-381: update model def api #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View issue in JIRA: AICORE-381: Update model definition api |
PedroCardoso
approved these changes
Nov 4, 2020
|
The server takes too much time to start. There is a new package |
| @@ -166,13 +165,12 @@ public Response getAllThresholds() { | |||
| @Path("extension/model") | |||
| @Consumes(MediaType.APPLICATION_XML) | |||
| @Produces(MediaType.APPLICATION_JSON) | |||
| public Response setModelFromXML(String modelXML) { | |||
| public Response setModelFromXML(@QueryParam("modelId") String modelId, String modelXML) { | |||
There was a problem hiding this comment.
why not a PathParam? Or at least there should be a null check
There was a problem hiding this comment.
- I have no opinion on the query param vs path param but I can change it for all endpoints
- Thanks for the review, i will check null
vpasquier
force-pushed
the
task-AICORE-381-update-model-def
branch
2 times, most recently
from
4f08492
to
06017e3
Compare
Comment on lines
205
to
207
| if(desc==null){ | ||
|
|
||
| } | ||
| if (desc instanceof ThresholdConfiguratorDescriptor) { |
|
The change 20adbd0 to 06017e3 broke testBulkEnrich – org.nuxeo.ai.bulk.BulkEnrichmentTest |
vpasquier
force-pushed
the
task-AICORE-381-update-model-def
branch
from
1b0d8f2
to
f09a77c
Compare
|
⭐ PR built and available in a preview environment nuxeo-nuxeo-ai-pr-276 here |
jcarsique
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.