Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXP-29949: add jenkins release job #12

Merged
merged 1 commit into from
Dec 17, 2020
Merged

NXP-29949: add jenkins release job #12

merged 1 commit into from
Dec 17, 2020

Conversation

doulba
Copy link
Contributor

@doulba doulba commented Dec 10, 2020

No description provided.

@nuxeojenkins
Copy link

View issue in JIRA: NXP-29949: [GLACIER] New job to promote a build version as a release

@doulba doulba force-pushed the improvement-NXP-29949-add-release-job branch from 61a6a47 to fb957a4 Compare December 10, 2020 14:38
@nuxeo-napps-jx-bot
Copy link
Collaborator

⭐ PR built and available in a preview environment coldstorage-pr-12 here

@doulba doulba changed the base branch from 2021 to lts-2021 December 14, 2020 08:34
@doulba doulba force-pushed the improvement-NXP-29949-add-release-job branch 2 times, most recently from 4ad3e1c to d1ad8d7 Compare December 14, 2020 09:10
@doulba doulba requested review from RSalem07, a team and pddgoncalves and removed request for a team December 15, 2020 08:15
@RSalem07
Copy link
Contributor

@doulba I haven't started the code review yet, but please find below some interrogations / suggestions:

  • JIRA https://jira.nuxeo.com/browse/NXP-29949 should has Cold Storage in the title, [GLACIER] New job to promote a build version as a release -> [Cold Storage] New job to promote a build version as a release.

  • On the JIRA description you talk about git checkout v3.0.0-rc.0, why v3.0.0-rc.0 it should be 2021.0.1 where 1 is the build number to promote.

  • Can you update the JIRA to include the component which is Glacier :) :(

I will start the code review asap.

thx

RSalem07
RSalem07 reviewed Dec 15, 2020
View reviewed changes
Copy link
Contributor

@RSalem07 RSalem07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some comments / suggestions.

@doulba doulba force-pushed the improvement-NXP-29949-add-release-job branch 2 times, most recently from 1922318 to 6844880 Compare December 15, 2020 16:25
@doulba doulba marked this pull request as ready for review December 15, 2020 16:29
@doulba doulba requested a review from RSalem07 December 15, 2020 16:30
@doulba doulba force-pushed the improvement-NXP-29949-add-release-job branch from 6844880 to 02492a1 Compare December 15, 2020 16:41
@doulba doulba force-pushed the improvement-NXP-29949-add-release-job branch 2 times, most recently from a4e890c to dd9f29c Compare December 17, 2020 08:42
@doulba doulba force-pushed the improvement-NXP-29949-add-release-job branch from dd9f29c to a4ce726 Compare December 17, 2020 08:52
@doulba doulba merged commit 7ae16a3 into lts-2021 Dec 17, 2020
@doulba doulba deleted the improvement-NXP-29949-add-release-job branch December 17, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RSalem07 RSalem07 RSalem07 approved these changes

@pddgoncalves pddgoncalves pddgoncalves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@doulba @nuxeojenkins @nuxeo-napps-jx-bot @RSalem07 @pddgoncalves