NXBT-3441: Fix target platform pattern matching when build number is 0 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjulienne-nuxeo
requested review from
troger,
akervern,
efge and
kevinleturc
|
View issue in JIRA: NXBT-3441: Fix Target Platform matching with 0 as build number |
kevinleturc
approved these changes
Nov 18, 2020
efge
requested changes
Nov 18, 2020
...client/src/main/java/org/nuxeo/connect/packages/dependencies/TargetPlatformFilterHelper.java
Outdated
Show resolved
Hide resolved
...client/src/main/java/org/nuxeo/connect/packages/dependencies/TargetPlatformFilterHelper.java
Outdated
Show resolved
Hide resolved
...client/src/main/java/org/nuxeo/connect/packages/dependencies/TargetPlatformFilterHelper.java
Outdated
Show resolved
Hide resolved
yjulienne-nuxeo
force-pushed
the
fix-NXBT-3441-tp-null-build-number-matching
branch
from
a1d38b4
to
6d0ae47
Compare
efge
requested changes
Nov 18, 2020
...nt/src/test/java/org/nuxeo/connect/packages/dependencies/TargetPlatformFilterHelperTest.java
Show resolved
Hide resolved
...nt/src/test/java/org/nuxeo/connect/packages/dependencies/TargetPlatformFilterHelperTest.java
Outdated
Show resolved
Hide resolved
yjulienne-nuxeo
force-pushed
the
fix-NXBT-3441-tp-null-build-number-matching
branch
from
6d0ae47
to
4686de6
Compare
jcarsique
approved these changes
Nov 19, 2020
yjulienne-nuxeo
deleted the
fix-NXBT-3441-tp-null-build-number-matching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.