NXDRIVE-2083: Use dict.copy() for thread safety, better atomicity spe…

[BoboTiG]

…ed and memory efficiency

References:

• https://bugs.python.org/issue13487
• https://bugs.python.org/issue40327

[nuxeojenkins]

View issues in JIRA:

• NXDRIVE-2223: Select Web UI by default in Settings
• NXDRIVE-2083: Use dict.copy() for thread safety, better atomicity speed and memory efficiency

[sourcery-ai]

Sourcery Code Quality Report (beta)

Merging this PR leaves code quality unchanged.

	Before	After	Change
Quality	8.49	8.49	0.0
Complexity	4.46	4.46	0.0
Method Length	63.05	63.05	0.0
Lines	3256	3255	-1

Changed files	Quality Before	Quality After	Quality Change
nxdrive/manager.py	8.85	8.85	0.0
nxdrive/engine/queue_manager.py	8.49	8.49	0.0
nxdrive/engine/watcher/local_watcher.py	7.71	7.71	0.0
nxdrive/updater/base.py	8.26	8.26	0.0
tests/functional/test_server_options.py	9.02	9.02	0.0

Here are some functions in these files that still need a tune-up:

File	Function	Quality	Recommendation
nxdrive/engine/watcher/local_watcher.py	LocalWatcher._scan_recursive	0.01	Reduce complexity. Split out functionality
nxdrive/engine/watcher/local_watcher.py	LocalWatcher.handle_watchdog_event	0.05	Reduce complexity. Split out functionality
nxdrive/engine/watcher/local_watcher.py	LocalWatcher._handle_watchdog_event_on_known_acquired_pair	2.01	Reduce complexity. Split out functionality
nxdrive/manager.py	Manager.__init__	2.73	Split out functionality
nxdrive/engine/watcher/local_watcher.py	LocalWatcher._handle_move_on_known_pair	3.03	Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!