Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2135: Check for proxy instantiation success when using a PAC #1925

Merged
merged 1 commit into from Aug 6, 2020

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Aug 6, 2020

Also set a lower logging level on proxy validation error to prevent Sentry events spam.

@BoboTiG BoboTiG added the bugfix label Aug 6, 2020
@BoboTiG BoboTiG added this to the 4.4.5 milestone Aug 6, 2020
@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2135: Check for proxy instanciation success when using a PAC

@BoboTiG BoboTiG force-pushed the wip-NXDRIVE-2135-better-check-for-pac branch 3 times, most recently from 2b436a2 to 60eb9c2 Compare August 6, 2020 16:00
@BoboTiG BoboTiG changed the title NXDRIVE-2135: Check for proxy instanciation success when using a PAC NXDRIVE-2135: Check for proxy instantiation success when using a PAC Aug 6, 2020
Also set a lower logging level on proxy validation error
to prevent Sentry events spam.
@BoboTiG BoboTiG force-pushed the wip-NXDRIVE-2135-better-check-for-pac branch from 60eb9c2 to bcf78a2 Compare August 6, 2020 16:04
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 6, 2020

Sourcery Code Quality Report (beta)

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.94 1.95 0.01 🔴
Method Length 42.73 42.81 0.08 🔴
Quality 8.87 8.87 0.00
Other metrics Before After Change
Lines 990 993 3
Changed files Quality Before Quality After Quality Change
nxdrive/manager.py 8.85 8.85 0.00
nxdrive/client/proxy.py 8.95 8.94 -0.01 🔴

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation
nxdrive/manager.py Manager.__init__ 26 443.49 2.73 Split out functionality
nxdrive/manager.py Manager.bind_engine 15 229.86 4.46 Split out functionality
nxdrive/client/proxy.py load_proxy 16 142.77 5.39 Split out functionality
nxdrive/manager.py Manager.get_server_login_type 8 144.83 6.11 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit 47a806c into master Aug 6, 2020
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2135-better-check-for-pac branch August 6, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants