Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2283: Ensure that get_tree_list() can actually browse a folder #1976

Merged
merged 2 commits into from Aug 31, 2020

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Aug 31, 2020

No description provided.

@BoboTiG BoboTiG added the bugfix label Aug 31, 2020
@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2283: Ensure that get_tree_list() can actually browse a folder

@BoboTiG BoboTiG added this to the 4.4.5 milestone Aug 31, 2020
@BoboTiG BoboTiG force-pushed the wip-NXDRIVE-2283-get_tree_list-scandir-error branch from c4db1b0 to 8d11274 Compare August 31, 2020 15:01
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 31, 2020

Sourcery Code Quality Report (beta)

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.82 1.82 0.00
Method Length 49.52 49.57 0.05 🔴
Quality 8.66 8.66 0.00
Other metrics Before After Change
Lines 1905 1912 7
Changed files Quality Before Quality After Quality Change
nxdrive/utils.py 8.37 8.37 0.00
tests/unit/test_utils.py 8.91 8.91 0.00

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation
tests/unit/test_utils.py test_save_config 22 288.26 3.46 Split out functionality
nxdrive/utils.py PidLockFile.check_running 17 147.82 5.22 Split out functionality
nxdrive/utils.py get_tree_list 13 142.92 5.66 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG requested a review from rom1win August 31, 2020 15:03
@BoboTiG BoboTiG merged commit 7518e92 into master Aug 31, 2020
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2283-get_tree_list-scandir-error branch August 31, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants