Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2019: Skip tests when the new API is not available #1984

Merged
merged 1 commit into from Sep 2, 2020

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Sep 2, 2020

No description provided.

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2019: [Direct Transfer] Enable folder uploads

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 2, 2020

Sourcery Code Quality Report (beta)

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.29 0.31 0.02 🔴
Method Length 53.69 53.90 0.21 🔴
Quality 8.71 8.71 0.00
Other metrics Before After Change
Lines 835 838 3
Changed files Quality Before Quality After Quality Change
tests/old_functional/test_direct_transfer.py 8.71 8.71 0.00

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation
tests/old_functional/test_direct_transfer.py DirectTransferFolder.test_same_name_folders 0 164.86 6.61 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit 3c8405b into master Sep 2, 2020
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2019-skip-tests-when-needed branch September 2, 2020 12:44
@BoboTiG BoboTiG added this to the 4.4.5 milestone Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants