New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXDRIVE-2076: Change the cursor on click on new account connect button #2024
NXDRIVE-2076: Change the cursor on click on new account connect button #2024
Conversation
View issue in JIRA: NXDRIVE-2076: Change the cursor on click on new account connect button |
5e66982
to
b975eb1
Compare
b975eb1
to
ba3fdad
Compare
self.manager.open_local_file(url) | ||
try: | ||
QApplication.setOverrideCursor(Qt.WaitCursor) | ||
webbrowser.open_new_tab(url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
When adding an account, the browser may take some time to open. A waiting cursor has been added so the user can know that something is currently happening. Also changelog has been updated.
ba3fdad
to
2c20c63
Compare
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.02%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
When adding an account, the browser may take some time
to open. A waiting cursor has been added so the user
can know that something is currently happening.
Also changelog has been updated.