Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2076: Change the cursor on click on new account connect button #2024

Merged

Conversation

rom1win
Copy link
Contributor

@rom1win rom1win commented Sep 17, 2020

When adding an account, the browser may take some time
to open. A waiting cursor has been added so the user
can know that something is currently happening.

Also changelog has been updated.

@rom1win rom1win added the QML label Sep 17, 2020
@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2076: Change the cursor on click on new account connect button

nxdrive/gui/application.py Outdated Show resolved Hide resolved
@rom1win rom1win force-pushed the wip-NXDRIVE-2076-change-cursor-on-new-account-connect branch 4 times, most recently from 5e66982 to b975eb1 Compare September 29, 2020 09:29
@rom1win rom1win force-pushed the wip-NXDRIVE-2076-change-cursor-on-new-account-connect branch from b975eb1 to ba3fdad Compare September 29, 2020 14:06
nxdrive/gui/application.py Outdated Show resolved Hide resolved
self.manager.open_local_file(url)
try:
QApplication.setOverrideCursor(Qt.WaitCursor)
webbrowser.open_new_tab(url)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

When adding an account, the browser may take some time
to open. A waiting cursor has been added so the user
can know that something is currently happening.

Also changelog has been updated.
@rom1win rom1win force-pushed the wip-NXDRIVE-2076-change-cursor-on-new-account-connect branch from ba3fdad to 2c20c63 Compare September 29, 2020 14:18
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 29, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 2.05 ⭐ 2.05 ⭐ 0.00
Method Length 71.30 🙂 71.44 🙂 0.14 👎
Working memory 5.85 ⭐ 5.85 ⭐ 0.00
Quality 83.00% 82.98% -0.02% 👎
Other metrics Before After Change
Lines 1657 1662 5
Changed files Quality Before Quality After Quality Change
nxdrive/gui/application.py 83.00% ⭐ 82.98% ⭐ -0.02% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/gui/application.py Application.accept_unofficial_ssl_cert 1 ⭐ 359 ⛔ 33 ⛔ 34.85% 😞 Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/application.py Application._fill_qml_context 2 ⭐ 285 ⛔ 27 ⛔ 36.74% 😞 Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/application.py Application.init_gui 5 ⭐ 476 ⛔ 12 😞 41.77% 😞 Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/application.py Application._handle_nxdrive_url 10 🙂 180 😞 15 😞 42.44% 😞 Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/application.py Application.confirm_deletion 7 ⭐ 215 ⛔ 11 😞 48.54% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit 03c2550 into master Sep 29, 2020
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2076-change-cursor-on-new-account-connect branch September 29, 2020 14:45
@BoboTiG BoboTiG added this to the 4.4.6 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants