Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts NXDRIVE-2406 and NXDRIVE-2407 #2253

Merged
merged 2 commits into from Nov 30, 2020
Merged

Reverts NXDRIVE-2406 and NXDRIVE-2407 #2253

merged 2 commits into from Nov 30, 2020

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Nov 30, 2020

Fixes done too quickly and introducting issues.

@BoboTiG BoboTiG added the bugfix label Nov 30, 2020
@nuxeojenkins
Copy link
Contributor

View issues in JIRA:

  • NXDRIVE-2407: Display 10 documents into the conflicts window
  • NXDRIVE-2406: Put duplicate documents into the ignore list

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 30, 2020

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 12.36 🙂 12.33 🙂 -0.03 👍
Method Length 59.25 ⭐ 59.14 ⭐ -0.11 👍
Working memory 10.38 😞 10.38 😞 0.00
Quality 64.20% 🙂 64.22% 🙂 0.02% 👍
Other metrics Before After Change
Lines 8475 8467 -8
Changed files Quality Before Quality After Quality Change
nxdrive/engine/engine.py 72.07% 🙂 72.07% 🙂 0.00%
nxdrive/engine/processor.py 34.90% 😞 34.94% 😞 0.04% 👍
nxdrive/engine/dao/sqlite.py 71.12% 🙂 71.13% 🙂 0.01% 👍
nxdrive/gui/api.py 75.60% ⭐ 75.61% ⭐ 0.01% 👍
nxdrive/gui/application.py 64.01% 🙂 64.02% 🙂 0.01% 👍
tests/unit/test_engine_dao.py 76.33% ⭐ 76.32% ⭐ -0.01% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/engine/processor.py Processor._synchronize_locally_created 98 ⛔ 887 ⛔ 25 ⛔ 2.11% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/engine/processor.py Processor._execute 139 ⛔ 1058 ⛔ 18 ⛔ 5.56% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/engine/processor.py Processor._synchronize_remotely_modified 33 ⛔ 322 ⛔ 25 ⛔ 12.82% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/engine/dao/sqlite.py EngineDAO.update_remote_state 24 😞 309 ⛔ 35 ⛔ 16.36% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/engine/dao/sqlite.py EngineDAO._migrate_db 32 😞 589 ⛔ 14 😞 18.51% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit 8305fd5 into master Nov 30, 2020
@BoboTiG BoboTiG deleted the wip-reverts branch November 30, 2020 16:03
@BoboTiG BoboTiG added this to the 4.5.0 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants