NXDRIVE-2363: [macOS] Fix auto-update issues

[BoboTiG]

• Fixed the SIGKILL:9 error when unmounting the volume. This was due to the xattr modification on the new folder. I am not sure why, but skipping that step fixed the issue.

• Fixed the SIGKILL:9 error when unloading the Finder extenstion. This was due to the fact that the extension was stopped twice. The second time ended on error.

• Removed the code looking for the FinderSync PID that was not working. The information is not really useful though.

• Use the plistlib module to find the volume mount point, more reliable and future proof.

[nuxeojenkins]

View issue in JIRA: NXDRIVE-2363: [macOS] Application auto-restart does not work since 4.3.0

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 2.27%.

Quality metrics	Before	After	Change
Complexity	2.47 ⭐	2.12 ⭐	-0.35 👍
Method Length	42.90 ⭐	42.54 ⭐	-0.36 👍
Working memory	7.79 🙂	7.41 🙂	-0.38 👍
Quality	76.99% ⭐	79.26% ⭐	2.27% 👍

Other metrics	Before	After	Change
Lines	503	523	20

Changed files	Quality Before	Quality After	Quality Change
nxdrive/osi/darwin/darwin.py	77.62% ⭐	78.30% ⭐	0.68% 👍
nxdrive/updater/darwin.py	72.36% 🙂	79.73% ⭐	7.37% 👍
nxdrive/updater/linux.py	81.50% ⭐	81.25% ⭐	-0.25% 👎
nxdrive/updater/windows.py	93.23% ⭐	91.98% ⭐	-1.25% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
nxdrive/osi/darwin/darwin.py	DarwinIntegration.send_content_sync_status	8 ⭐	104 🙂	14 😞	54.00% 🙂	Extract out complex expressions
nxdrive/osi/darwin/darwin.py	DarwinIntegration.is_partition_supported	5 ⭐	101 🙂	14 😞	57.29% 🙂	Extract out complex expressions
nxdrive/osi/darwin/darwin.py	DarwinIntegration.register_contextual_menu	0 ⭐	44 ⭐	10 😞	77.45% ⭐	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.