Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2433: Fix cancel button become disabled after transfer removal #2296

Merged
merged 1 commit into from Dec 10, 2020

Conversation

rom1win
Copy link
Contributor

@rom1win rom1win commented Dec 10, 2020

When cancelling a transfer in the Monitoring tab, the
next transfer that will replace him will have it's button
disabled.

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2433: [Direct Transfer] Remove pause button on the monitoring tab

nxdrive/gui/application.py Outdated Show resolved Hide resolved
nxdrive/data/qml/TransferItem.qml Show resolved Hide resolved
nxdrive/data/qml/TransferItem.qml Outdated Show resolved Hide resolved
@rom1win rom1win force-pushed the wip-NXDRIVE-2433-fix-cancel-button-become-disabled branch from 1bfdecc to 4aa90e1 Compare December 10, 2020 16:41
When cancelling a transfer in the Monitoring tab, the
next transfer that will replace him will have it's button
disabled.
@rom1win rom1win force-pushed the wip-NXDRIVE-2433-fix-cancel-button-become-disabled branch from 4aa90e1 to 1a1a80d Compare December 10, 2020 16:48
@rom1win rom1win marked this pull request as ready for review December 10, 2020 16:48
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 10, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.01%.

Quality metrics Before After Change
Complexity 4.67 ⭐ 4.67 ⭐ 0.00
Method Length 52.62 ⭐ 52.67 ⭐ 0.05 👎
Working memory 10.32 😞 10.33 😞 0.01 👎
Quality 68.30% 🙂 68.29% 🙂 -0.01% 👎
Other metrics Before After Change
Lines 5061 5062 1
Changed files Quality Before Quality After Quality Change
nxdrive/engine/dao/sqlite.py 71.07% 🙂 71.06% 🙂 -0.01% 👎
nxdrive/gui/application.py 63.71% 🙂 63.67% 🙂 -0.04% 👎
nxdrive/gui/view.py 71.13% 🙂 71.16% 🙂 0.03% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/engine/dao/sqlite.py EngineDAO.update_remote_state 24 😞 309 ⛔ 35 ⛔ 16.36% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/engine/dao/sqlite.py EngineDAO._migrate_db 32 😞 589 ⛔ 14 😞 18.51% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/view.py ActiveSessionModel.data 23 😞 229 ⛔ 17 ⛔ 26.53% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/view.py CompletedSessionModel.data 23 😞 225 ⛔ 17 ⛔ 26.77% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/application.py Application._fill_qml_context 3 ⭐ 333 ⛔ 28 ⛔ 34.08% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit ecad227 into master Dec 10, 2020
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2433-fix-cancel-button-become-disabled branch December 10, 2020 16:50
@BoboTiG BoboTiG added this to the 4.5.0 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants