Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2329: Add a metric #2392

Merged
merged 2 commits into from Jan 18, 2021
Merged

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Jan 18, 2021

No description provided.

@nuxeojenkins
Copy link
Contributor

View issues in JIRA:

  • NXDRIVE-2329: [Direct Transfer] Add a button to create a folder within the upload flow
  • NXDRIVE-2438: Cancel folder transfer when selecting a folder with the same name

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 18, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.29%.

Quality metrics Before After Change
Complexity 3.34 ⭐ 3.38 ⭐ 0.04 👎
Method Length 49.12 ⭐ 49.38 ⭐ 0.26 👎
Working memory 7.67 🙂 7.77 🙂 0.10 👎
Quality 75.90% 75.61% -0.29% 👎
Other metrics Before After Change
Lines 937 942 5
Changed files Quality Before Quality After Quality Change
nxdrive/engine/engine.py 75.58% ⭐ 75.58% ⭐ 0.00%
nxdrive/gui/folders_dialog.py 76.65% ⭐ 75.69% ⭐ -0.96% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/engine/engine.py Engine._check_last_sync 7 ⭐ 154 😞 19 ⛔ 43.99% 😞 Try splitting into smaller methods. Extract out complex expressions
nxdrive/engine/engine.py Engine.export 1 ⭐ 81 🙂 41 ⛔ 54.46% 🙂 Extract out complex expressions
nxdrive/engine/engine.py Engine.stop 10 🙂 181 😞 8 🙂 54.50% 🙂 Try splitting into smaller methods
nxdrive/gui/folders_dialog.py DocumentsDialog.apply_filters 13 🙂 93 🙂 11 😞 55.70% 🙂 Extract out complex expressions
nxdrive/gui/folders_dialog.py FoldersDialog._find_folders_duplicates 6 ⭐ 81 🙂 13 😞 60.57% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit 098c27c into master Jan 18, 2021
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2446-metric-dt-session-time branch January 18, 2021 16:06
@BoboTiG BoboTiG added this to the 4.5.1 milestone Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants