Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2509: Remove old report before starting a test #2451

Merged
merged 1 commit into from Feb 8, 2021

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Feb 8, 2021

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 8, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.35%.

Quality metrics Before After Change
Complexity 8.13 ⭐ 8.04 ⭐ -0.09 👍
Method Length 71.60 🙂 70.46 🙂 -1.14 👍
Working memory 10.84 😞 10.77 😞 -0.07 👍
Quality 58.17% 🙂 58.52% 🙂 0.35% 👍
Other metrics Before After Change
Lines 809 817 8
Changed files Quality Before Quality After Quality Change
tests/old_functional/common.py 58.17% 🙂 58.52% 🙂 0.35% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tests/old_functional/common.py TwoUsersTest.wait_sync 28 😞 320 ⛔ 14 😞 23.13% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tests/old_functional/common.py OneUserTest.wait_sync 22 😞 237 ⛔ 12 😞 33.07% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tests/old_functional/common.py TwoUsersTest._append_user_attrs 1 ⭐ 282 ⛔ 24 ⛔ 38.69% 😞 Try splitting into smaller methods. Extract out complex expressions
tests/old_functional/common.py TwoUsersTest.setup_method 6 ⭐ 199 😞 12 😞 48.92% 😞 Try splitting into smaller methods. Extract out complex expressions
tests/old_functional/common.py TwoUsersTest.generate_report 7 ⭐ 91 🙂 18 ⛔ 52.51% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit 96b33d9 into master Feb 8, 2021
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2509-delete-old-report-in-test branch February 8, 2021 10:23
@BoboTiG BoboTiG added this to the 5.0.0 milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants