NXDRIVE-2523: Prevent crashes because of too many opened file descrip…

[BoboTiG]

…tors

The issue was not visible quickly but when Drive was running a long time with a lot of synchronization actions. Each thread was opening a connection to the SQLite database file, but it was never released.

[nuxeojenkins]

View issue in JIRA: NXDRIVE-2523: Prevent crashes because of too many opened file descriptors

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.23%.

Quality metrics	Before	After	Change
Complexity	1.21 ⭐	1.17 ⭐	-0.04 👍
Method Length	49.93 ⭐	49.31 ⭐	-0.62 👍
Working memory	7.57 🙂	7.41 🙂	-0.16 👍
Quality	78.00% ⭐	78.23% ⭐	0.23% 👍

Other metrics	Before	After	Change
Lines	1025	1010	-15

Changed files	Quality Before	Quality After	Quality Change
nxdrive/engine/dao/sqlite.py	80.15% ⭐	80.75% ⭐	0.60% 👍
tests/unit/test_engine_dao.py	75.96% ⭐	75.96% ⭐	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
nxdrive/engine/dao/sqlite.py	EngineDAO.get_dt_uploads_raw	3 ⭐	74 🙂	26 ⛔	55.00% 🙂	Extract out complex expressions
nxdrive/engine/dao/sqlite.py	EngineDAO.get_completed_sessions_raw	0 ⭐	68 🙂	31 ⛔	58.01% 🙂	Extract out complex expressions
tests/unit/test_engine_dao.py	test_configuration_get_bool	0 ⭐	283 ⛔	8 🙂	58.08% 🙂	Try splitting into smaller methods
nxdrive/engine/dao/sqlite.py	EngineDAO.get_active_sessions_raw	0 ⭐	65 🙂	30 ⛔	58.60% 🙂	Extract out complex expressions
nxdrive/engine/dao/sqlite.py	EngineDAO.get_dt_uploads	2 ⭐	64 🙂	19 ⛔	60.67% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.