NXDRIVE-2607: Handle invalid data returned by the server when asking for a batchId

[rom1win]

Co-authored-by: Romain Grasland rgrasland@nuxeo.com

[nuxeojenkins]

View issue in JIRA: NXDRIVE-2607: Handle invalid data returned by the server when asking for a batchId

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.06%.

Quality metrics	Before	After	Change
Complexity	1.05 ⭐	1.05 ⭐	0.00
Method Length	69.32 🙂	70.71 🙂	1.39 👎
Working memory	8.97 🙂	8.97 🙂	0.00
Quality	68.35% 🙂	68.29% 🙂	-0.06% 👎

Other metrics	Before	After	Change
Lines	1032	1073	41

Changed files	Quality Before	Quality After	Quality Change
nxdrive/client/uploader/init.py	88.26% ⭐	88.03% ⭐	-0.23% 👎
tests/old_functional/test_transfer.py	68.19% 🙂	68.13% 🙂	-0.06% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
tests/old_functional/test_transfer.py	TestDownload.test_pause_download_manually	4 ⭐	173 😞	14 😞	50.06% 🙂	Try splitting into smaller methods. Extract out complex expressions
tests/old_functional/test_transfer.py	TestUpload.test_server_error_but_upload_ok_idempotent_call	0 ⭐	211 ⛔	13 😞	52.41% 🙂	Try splitting into smaller methods. Extract out complex expressions
tests/old_functional/test_transfer.py	TestUpload.test_chunk_upload_error_then_server_error_at_linking	2 ⭐	275 ⛔	9 🙂	54.19% 🙂	Try splitting into smaller methods
tests/old_functional/test_transfer.py	TestDownload.test_modifying_paused_download	4 ⭐	147 😞	12 😞	55.63% 🙂	Try splitting into smaller methods. Extract out complex expressions
tests/old_functional/test_transfer.py	TestDownload.test_deleting_paused_download	2 ⭐	134 😞	12 😞	59.07% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

[codecov]

Codecov Report

Merging #2630 (d5f4cdf) into master (9582582) will decrease coverage by 12.20%.
The diff coverage is 14.28%.

@@             Coverage Diff             @@
##           master    #2630       +/-   ##
===========================================
- Coverage   43.52%   31.32%   -12.21%     
===========================================
  Files          77       77               
  Lines       14630    14636        +6     
===========================================
- Hits         6367     4584     -1783     
- Misses       8263    10052     +1789     

Flag	Coverage Δ
functional	?
integration	?
unit	31.32% <14.28%> (-3.00%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
nxdrive/client/uploader/__init__.py	21.39% <14.28%> (-0.16%)	⬇️
nxdrive/client/local/windows.py	0.00% <0.00%> (-91.35%)	⬇️
nxdrive/client/local/darwin.py	0.00% <0.00%> (-90.42%)	⬇️
nxdrive/osi/windows/files.py	0.00% <0.00%> (-82.36%)	⬇️
nxdrive/osi/windows/registry.py	1.42% <0.00%> (-80.00%)	⬇️
nxdrive/osi/windows/windows.py	0.00% <0.00%> (-69.68%)	⬇️
nxdrive/updater/windows.py	0.00% <0.00%> (-66.67%)	⬇️
nxdrive/osi/darwin/extension.py	0.00% <0.00%> (-65.00%)	⬇️
nxdrive/osi/windows/extension.py	0.00% <0.00%> (-63.27%)	⬇️
nxdrive/osi/darwin/darwin.py	0.00% <0.00%> (-52.64%)	⬇️
... and 31 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9582582...d5f4cdf. Read the comment docs.