Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2610: Remove the TRACE logging level, obsolete since 4.1.0 #2635

Merged
merged 1 commit into from Apr 23, 2021

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Apr 23, 2021

No description provided.

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2610: Remove the obsolete TRACE logging level

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 23, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.59%.

Quality metrics Before After Change
Complexity 3.01 ⭐ 3.01 ⭐ 0.00
Method Length 63.50 🙂 63.41 🙂 -0.09 👍
Working memory 8.69 🙂 8.34 🙂 -0.35 👍
Quality 65.32% 🙂 65.91% 🙂 0.59% 👍
Other metrics Before After Change
Lines 571 571 0
Changed files Quality Before Quality After Quality Change
nxdrive/commandline.py 61.64% 🙂 62.69% 🙂 1.05% 👍
nxdrive/logging_config.py 70.14% 🙂 70.14% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/logging_config.py configure 10 🙂 199 😞 11 😞 46.88% 😞 Try splitting into smaller methods. Extract out complex expressions
nxdrive/commandline.py CliHandler.make_cli_parser 1 ⭐ 613 ⛔ 11 😞 47.00% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit 609c078 into master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants