Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2661: Set a higher logging level for Options changes #2766

Merged
merged 1 commit into from May 28, 2021

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented May 28, 2021

To ease debugging, Options changes are now logged at INFO level.

To ease debugging, `Options` changes are now logged at `INFO` level.
@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2661: DEBUG message should be at INFO level

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 28, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.54 ⭐ 0.54 ⭐ 0.00
Method Length 35.46 ⭐ 35.46 ⭐ 0.00
Working memory 6.52 🙂 6.52 🙂 0.00
Quality 84.18% 84.18% 0.00%
Other metrics Before After Change
Lines 197 197 0
Changed files Quality Before Quality After Quality Change
nxdrive/options.py 84.18% ⭐ 84.18% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/options.py _get_home 1 ⭐ 38 ⭐ 10 😞 77.43% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #2766 (f7b8328) into master (998f714) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   44.36%   44.15%   -0.21%     
==========================================
  Files          85       85              
  Lines       14888    14888              
==========================================
- Hits         6605     6574      -31     
- Misses       8283     8314      +31     
Flag Coverage Δ
functional 35.49% <100.00%> (ø)
unit 33.04% <100.00%> (-1.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nxdrive/options.py 100.00% <100.00%> (ø)
nxdrive/osi/windows/registry.py 50.00% <0.00%> (-31.43%) ⬇️
nxdrive/osi/windows/files.py 52.94% <0.00%> (-29.42%) ⬇️
nxdrive/client/local/windows.py 90.38% <0.00%> (-0.97%) ⬇️
nxdrive/osi/windows/windows.py 67.58% <0.00%> (-0.69%) ⬇️
nxdrive/engine/dao/engine.py 59.26% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998f714...f7b8328. Read the comment docs.

@BoboTiG BoboTiG merged commit b9ee544 into master May 28, 2021
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2661-options-changes-log-level branch May 28, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants