Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2689: Test test_wrong_server_reply() #2835

Merged
merged 1 commit into from Jun 16, 2021

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Jun 16, 2021

No description provided.

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2689: Fix test_wrong_server_reply()

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 16, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.61%.

Quality metrics Before After Change
Complexity 1.40 ⭐ 1.38 ⭐ -0.02 👍
Method Length 46.33 ⭐ 48.00 ⭐ 1.67 👎
Working memory 6.74 🙂 6.92 🙂 0.18 👎
Quality 77.93% 77.32% -0.61% 👎
Other metrics Before After Change
Lines 73 77 4
Changed files Quality Before Quality After Quality Change
tests/functional/test_remote_changes.py 77.93% ⭐ 77.32% ⭐ -0.61% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tests/functional/test_remote_changes.py test_changes_without_active_roots 2 ⭐ 123 😞 9 🙂 66.07% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #2835 (58d4cb9) into master (4c772af) will decrease coverage by 9.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2835      +/-   ##
==========================================
- Coverage   44.70%   35.40%   -9.31%     
==========================================
  Files          90       90              
  Lines       15040    15040              
==========================================
- Hits         6724     5325    -1399     
- Misses       8316     9715    +1399     
Flag Coverage Δ
functional 35.40% <ø> (+0.13%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nxdrive/dao/migrations/migration.py 0.00% <0.00%> (-100.00%) ⬇️
nxdrive/dao/migrations/engine/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
nxdrive/dao/migrations/manager/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
...ve/dao/migrations/engine/0021_initial_migration.py 0.00% <0.00%> (-100.00%) ⬇️
...e/dao/migrations/manager/0004_initial_migration.py 0.00% <0.00%> (-100.00%) ⬇️
nxdrive/report.py 0.00% <0.00%> (-68.92%) ⬇️
nxdrive/tracing.py 0.00% <0.00%> (-66.67%) ⬇️
nxdrive/commandline.py 0.00% <0.00%> (-57.43%) ⬇️
nxdrive/engine/blocklist_queue.py 44.44% <0.00%> (-46.30%) ⬇️
nxdrive/autolocker.py 38.59% <0.00%> (-44.74%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c772af...58d4cb9. Read the comment docs.

@BoboTiG BoboTiG merged commit 8a2e9f4 into master Jun 16, 2021
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2689-fix-test_remote_changes branch June 16, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants