Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2721: [Windows] Correctly handle WinError 32 #2911

Merged
merged 1 commit into from Jul 8, 2021

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Jul 8, 2021

Co-authored-by: Romain Grasland rgrasland@nuxeo.com

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2721: [Windows] Correctly handle WinError 32

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #2911 (69f257e) into master (5985f19) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2911   +/-   ##
=======================================
  Coverage   45.23%   45.23%           
=======================================
  Files          91       91           
  Lines       15192    15192           
=======================================
  Hits         6872     6872           
  Misses       8320     8320           
Flag Coverage Δ
functional 35.85% <ø> (ø)
unit 35.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nxdrive/engine/queue_manager.py 37.91% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5985f19...69f257e. Read the comment docs.

Co-authored-by: Romain Grasland <rgrasland@nuxeo.com>
@BoboTiG BoboTiG force-pushed the wip-NXDRIVE-2721-win-error-32 branch from 06714fe to 69f257e Compare July 8, 2021 09:43
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 8, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 5.44 ⭐ 5.44 ⭐ 0.00
Method Length 40.79 ⭐ 40.79 ⭐ 0.00
Working memory 4.79 ⭐ 4.79 ⭐ 0.00
Quality 82.08% 82.08% 0.00%
Other metrics Before After Change
Lines 291 291 0
Changed files Quality Before Quality After Quality Change
nxdrive/engine/queue_manager.py 82.08% ⭐ 82.08% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/engine/queue_manager.py QueueManager.launch_processors 16 🙂 164 😞 9 🙂 48.69% 😞 Try splitting into smaller methods
nxdrive/engine/queue_manager.py QueueItem.__repr__ 0 ⭐ 24 ⭐ 10 😞 80.74% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@BoboTiG BoboTiG merged commit 4336666 into master Jul 8, 2021
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2721-win-error-32 branch July 8, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants