Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2730: Fix keyPressEvent method #3014

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

rom1win
Copy link
Contributor

@rom1win rom1win commented Aug 13, 2021

No description provided.

@rom1win rom1win added the bugfix label Aug 13, 2021
@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2730: [macOS] Fix windows maximization not being reversible

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 13, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.97%.

Quality metrics Before After Change
Complexity 0.70 ⭐ 1.09 ⭐ 0.39 👎
Method Length 17.25 ⭐ 18.75 ⭐ 1.50 👎
Working memory 5.00 ⭐ 5.09 ⭐ 0.09 👎
Quality 92.85% 91.88% -0.97% 👎
Other metrics Before After Change
Lines 17 19 2
Changed files Quality Before Quality After Quality Change
nxdrive/gui/custom_window.py 92.85% ⭐ 91.88% ⭐ -0.97% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #3014 (2e7d6ea) into master (5945d46) will decrease coverage by 2.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3014      +/-   ##
==========================================
- Coverage   45.29%   43.20%   -2.09%     
==========================================
  Files          92       92              
  Lines       15274    15276       +2     
==========================================
- Hits         6918     6600     -318     
- Misses       8356     8676     +320     
Flag Coverage Δ
functional 34.07% <0.00%> (-1.87%) ⬇️
integration ?
unit 34.03% <0.00%> (-1.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nxdrive/gui/custom_window.py 0.00% <0.00%> (ø)
nxdrive/osi/windows/files.py 0.00% <0.00%> (-82.36%) ⬇️
nxdrive/osi/windows/registry.py 1.42% <0.00%> (-80.00%) ⬇️
nxdrive/client/local/windows.py 0.00% <0.00%> (-79.81%) ⬇️
nxdrive/osi/windows/windows.py 0.00% <0.00%> (-69.66%) ⬇️
nxdrive/updater/windows.py 0.00% <0.00%> (-66.67%) ⬇️
nxdrive/osi/windows/extension.py 0.00% <0.00%> (-63.27%) ⬇️
nxdrive/updater/__init__.py 84.61% <0.00%> (-7.70%) ⬇️
nxdrive/metrics/utils.py 92.59% <0.00%> (-7.41%) ⬇️
nxdrive/osi/__init__.py 69.23% <0.00%> (-3.85%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5945d46...2e7d6ea. Read the comment docs.

@rom1win rom1win merged commit a37ce8f into master Aug 13, 2021
@rom1win rom1win deleted the wip-NXDRIVE-2730-fix-key-press-method branch August 13, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants