Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2812: Update Github Action for set-output and save-state #3766

Conversation

swetayadav1
Copy link
Collaborator

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 27, 2023

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 17.14 🙂 17.14 🙂 0.00
Method Length 128.86 😞 128.86 😞 0.00
Working memory 10.66 😞 10.66 😞 0.00
Quality 44.29% 😞 44.29% 😞 0.00%
Other metrics Before After Change
Lines 1047 1047 0
Changed files Quality Before Quality After Quality Change
nxdrive/direct_edit.py 44.29% 😞 44.29% 😞 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/direct_edit.py DirectEdit._handle_upload_queue 48 ⛔ 582 ⛔ 18 ⛔ 9.31% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/direct_edit.py DirectEdit._prepare_edit 21 😞 456 ⛔ 18 ⛔ 21.04% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/direct_edit.py DirectEdit._handle_lock_queue 29 😞 365 ⛔ 13 😞 23.01% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/direct_edit.py DirectEdit._cleanup 22 😞 292 ⛔ 26.71% 😞 Refactor to reduce nesting. Try splitting into smaller methods
nxdrive/direct_edit.py DirectEdit._download 20 😞 251 ⛔ 15 😞 29.45% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +9.25 🎉

Comparison is base (2bdb332) 36.38% compared to head (af9acb1) 45.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3766      +/-   ##
==========================================
+ Coverage   36.38%   45.63%   +9.25%     
==========================================
  Files          93       93              
  Lines       15640    15640              
==========================================
+ Hits         5690     7137    +1447     
+ Misses       9950     8503    -1447     
Flag Coverage Δ
functional 36.35% <ø> (-0.03%) ⬇️
unit 35.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mr-shekhar mr-shekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mr-shekhar mr-shekhar merged commit 982289e into master May 19, 2023
10 of 11 checks passed
@mr-shekhar mr-shekhar deleted the wip-NXDRIVE-2812-Update-github-action-for-set-output-and-save-state branch May 19, 2023 07:54
gitofanindya pushed a commit that referenced this pull request Mar 15, 2024
* NXDRIVE-2812: Update github action for set-output and save-state
---------

Co-authored-by: mr-shekhar <85621953+mr-shekhar@users.noreply.github.com>
Co-authored-by: poojadaine <126543069+poojadaine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants