Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2830: Do not rename locally when a new account is added #3905

Conversation

gitofanindya
Copy link
Collaborator

NXDRIVE-2830: Do not rename locally when a new account is added

gitofanindya and others added 19 commits March 30, 2023 15:40
…ted.."

This reverts commit 4310c02.

"Reverted to previous commit"
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17 🎉

Comparison is base (0c5ab6f) 45.21% compared to head (c249b4d) 45.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3905      +/-   ##
==========================================
+ Coverage   45.21%   45.39%   +0.17%     
==========================================
  Files          93       93              
  Lines       15638    15640       +2     
==========================================
+ Hits         7071     7100      +29     
+ Misses       8567     8540      -27     
Flag Coverage Δ
functional 36.00% <100.00%> (+0.18%) ⬆️
integration 1.98% <0.00%> (-0.01%) ⬇️
unit 35.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nxdrive/engine/watcher/remote_watcher.py 18.95% <100.00%> (+4.96%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gitofanindya gitofanindya force-pushed the wip-NXDRIVE-2830-Do-not-rename-locally-when-a-new-account-is-added branch from 0b6aa3f to c249b4d Compare April 20, 2023 15:53
Copy link
Collaborator

@mr-shekhar mr-shekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gitofanindya gitofanindya merged commit f7289e2 into master Apr 20, 2023
@gitofanindya gitofanindya deleted the wip-NXDRIVE-2830-Do-not-rename-locally-when-a-new-account-is-added branch April 20, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants