Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXDRIVE-2920: Upgrade to TLS 1.2 #4780

Merged
merged 6 commits into from
May 28, 2024
Merged

NXDRIVE-2920: Upgrade to TLS 1.2 #4780

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85d056b
NXDRIVE: Fix use of insecure SSL/TLS version: security alert-#4
swetayadav1 Apr 3, 2024
f89e90e
NXDRIVE-2920: Upgrade to TLS 1.2
swetayadav1 Apr 10, 2024
f6cb716
NXDRIVE-2920: Upgrade to TLS 1.2
swetayadav1 Apr 12, 2024
75bc2f3
NXDRIVE-2920: Upgrade to TLS 1.2
swetayadav1 Apr 15, 2024
b6166d9
NXDRIVE-2920: Upgrade to TLS 1.2
swetayadav1 Apr 15, 2024
810c079
Merge branch 'master' of https://github.com/nuxeo/nuxeo-drive into wi…
swetayadav1 May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/changes/5.5.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Release date: `2024-xx-xx`

- [NXDRIVE-2882](https://jira.nuxeo.com/browse/NXDRIVE-2882): fix_db should create dump.sql in same dir as db
- [NXDRIVE-2901](https://jira.nuxeo.com/browse/NXDRIVE-2901): Authorization Error for OAuth
- [NXDRIVE-2](https://jira.nuxeo.com/browse/NXDRIVE-2):
- [NXDRIVE-2920](https://jira.nuxeo.com/browse/NXDRIVE-2920): Upgrade to TLS 1.2

### Direct Edit

Expand Down
5 changes: 4 additions & 1 deletion nxdrive/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,10 @@ def retrieve_ssl_certificate(hostname: str, /, *, port: int = 443) -> str:
import ssl

with ssl.create_connection((hostname, port)) as conn: # type: ignore
with ssl.SSLContext().wrap_socket(conn, server_hostname=hostname) as sock:
# Declaring a minimum version to restrict the protocol
context = ssl.create_default_context()
context.minimum_version = ssl.TLSVersion.TLSv1_2
swetayadav1 marked this conversation as resolved.
Show resolved Hide resolved
with context.wrap_socket(conn, server_hostname=hostname) as sock:
cert_data: bytes = sock.getpeercert(binary_form=True) # type: ignore
return ssl.DER_cert_to_PEM_cert(cert_data)

Expand Down