Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2889: Display system notification for document review(Bug Fix) #5001

Conversation

swetayadav1
Copy link
Contributor

No description provided.

Copy link
Contributor

sourcery-ai bot commented Jun 17, 2024

🧙 Sourcery is reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

nxdrive/client/workflow/__init__.py Show resolved Hide resolved
tests/unit/test_workflow.py Outdated Show resolved Hide resolved
tests/unit/test_workflow.py Show resolved Hide resolved
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.08%. Comparing base (1befb08) to head (ff7e85a).

Files Patch % Lines
nxdrive/gui/application.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                              Coverage Diff                              @@
##           wip-NXDRIVE-2873-Handle-workflow-in-drive    #5001      +/-   ##
=============================================================================
+ Coverage                                      50.95%   51.08%   +0.13%     
=============================================================================
  Files                                             95       95              
  Lines                                          15799    15825      +26     
=============================================================================
+ Hits                                            8050     8084      +34     
+ Misses                                          7749     7741       -8     
Flag Coverage Δ
functional 38.16% <27.65%> (+0.03%) ⬆️
integration 2.04% <0.00%> (-0.01%) ⬇️
unit 40.51% <85.10%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swetayadav1 swetayadav1 merged commit d68236d into wip-NXDRIVE-2873-Handle-workflow-in-drive Jun 21, 2024
22 checks passed
@swetayadav1 swetayadav1 deleted the wip-NXDRIVE-2889-Display-system-notification-for-document-review-fix branch June 21, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant