Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELEMENTS-1200: filter nuxeo-preview-button based on xpath #256

Merged
merged 1 commit into from Jul 6, 2020
Merged

ELEMENTS-1200: filter nuxeo-preview-button based on xpath #256

merged 1 commit into from Jul 6, 2020

Conversation

richardsd
Copy link
Contributor

@richardsd richardsd commented Jun 22, 2020 •
edited

No description provided.

@richardsd richardsd requested a review from a team as a code owner June 22, 2020 17:00
@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXP-29218: Preview button for attachments is filtered out wrongly

@richardsd richardsd force-pushed the fix-NXP-29218-preview-button-filtering branch from 58e4ad8 to 2a07f37 Compare June 23, 2020 13:28
@richardsd richardsd requested a review from semisse June 23, 2020 13:34
@richardsd richardsd changed the title NXP-29218: fix preview button availability for documents with attachm… NXP-29218: filter nuxeo-preview-button based on xpath Jun 23, 2020
semisse
semisse previously approved these changes Jun 23, 2020
View reviewed changes
@nuxeo-web-ui-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-elements-pr-256 here

@richardsd richardsd requested a review from Gabez0r June 24, 2020 11:42
Gabez0r
Gabez0r reviewed Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@Gabez0r Gabez0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to use an ELEMENTS ticket, though.

@richardsd richardsd force-pushed the fix-NXP-29218-preview-button-filtering branch from 2a07f37 to 5cd1539 Compare June 24, 2020 13:01
@richardsd richardsd changed the title NXP-29218: filter nuxeo-preview-button based on xpath ELEMENTS-1200: filter nuxeo-preview-button based on xpath Jun 24, 2020
@richardsd richardsd force-pushed the fix-NXP-29218-preview-button-filtering branch from 5cd1539 to ce9132a Compare June 24, 2020 13:02
@richardsd
Copy link
Contributor Author

LGTM. We need to use an ELEMENTS ticket, though.

Thanks. I updated the commit message and moved to an ELEMENTS ticket.

@nuxeo-web-ui-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-elements-pr-256 here

@richardsd richardsd merged commit d30993b into master Jul 6, 2020
@richardsd richardsd deleted the fix-NXP-29218-preview-button-filtering branch July 6, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnixo mnixo mnixo approved these changes

@Gabez0r Gabez0r Gabez0r approved these changes

@guirenard guirenard Awaiting requested review from guirenard

@semisse semisse Awaiting requested review from semisse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@richardsd @nuxeojenkins @nuxeo-web-ui-jx-bot @semisse @mnixo @Gabez0r