ELEMENTS-1209: use WriteProperties instead of Write in nuxeo-delete-blob-button #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View issue in JIRA: ELEMENTS-1209: Update nuxeo-delete-blob-button to use WriteProperties permission |
Gabez0r
previously approved these changes
Aug 5, 2020
| }, | ||
| }; | ||
| await flush(); | ||
| expect(isElementVisible(getActionDiv(button))).to.be.true; |
There was a problem hiding this comment.
nit: since isElementVisible is always used with getActionDiv, we could renamed and make getActionDiv also call isElementVisible on the button.
|
⭐ PR built and available in a preview environment nuxeo-nuxeo-elements-pr-267 here |
mnixo
force-pushed
the
improvement-ELEMENTS-1209-nuxeo-delete-blob-button-writeproperties
branch
from
0ccb283
to
d86ca61
Compare
Gabez0r
approved these changes
Aug 6, 2020
|
⭐ PR built and available in a preview environment nuxeo-nuxeo-elements-pr-267 here |
semisse
approved these changes
Aug 10, 2020
richardsd
approved these changes
Aug 11, 2020
mnixo
deleted the
improvement-ELEMENTS-1209-nuxeo-delete-blob-button-writeproperties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.