Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELEMENTS-1230: fix overflow in nuxeo-data-table #273

Merged
merged 1 commit into from Sep 2, 2020

Conversation

nuxeojenkins
Copy link
Contributor

This Pull Request looks good!

@nuxeojenkins
Copy link
Contributor Author

View issue in JIRA: NXP-29440: Fix the display of a multiple suggestion in the nuxeo-data-table header

@semisse semisse requested review from Gabez0r and mnixo August 11, 2020 10:48
richardsd
richardsd previously approved these changes Aug 18, 2020
mnixo
mnixo previously approved these changes Aug 26, 2020
Copy link
Collaborator

@Gabez0r Gabez0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks good to me. But please, convert it to a ELEMENTS ticket first and amend the commit. Also, I see the ticket is in review, but please do not forget about the backports!

Copy link
Collaborator

@Gabez0r Gabez0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting changes because I saw the PR had two reviews already. Please see my comment above.

@semisse semisse dismissed stale reviews from mnixo and richardsd via cae8bf8 August 26, 2020 18:35
@semisse semisse force-pushed the fix-NXP-29440-overflowInNuxeoSelectivity branch from 5ab85c8 to cae8bf8 Compare August 26, 2020 18:35
@semisse semisse changed the title fix-NXP-29440-overflowInNuxeoSelectivity ELEMENTS-1230: fix overflow in nuxeo-data-table Aug 26, 2020
@nuxeo-web-ui-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-elements-pr-273 here

@semisse semisse merged commit b413c50 into master Sep 2, 2020
@semisse semisse deleted the fix-NXP-29440-overflowInNuxeoSelectivity branch September 2, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants