Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELEMENTS-1226: vertical alignment consistency with new typography #305

Merged
merged 21 commits into from Nov 17, 2020
Merged

ELEMENTS-1226: vertical alignment consistency with new typography #305

merged 21 commits into from Nov 17, 2020

Conversation

semisse
Copy link
Collaborator

@semisse semisse commented Oct 29, 2020

No description provided.

@nuxeojenkins
Copy link
Contributor

View issues in JIRA:

@semisse semisse requested a review from Gabez0r October 29, 2020 16:51
@semisse semisse mentioned this pull request Oct 30, 2020
Closed
@semisse semisse force-pushed the imp-ELEMENTS-1226-verticalAlignmentConsistencyWithNewTypography branch from 326e03a to ede833f Compare November 2, 2020 20:54
@semisse semisse marked this pull request as ready for review November 3, 2020 11:12
@semisse semisse requested a review from a team as a code owner November 3, 2020 11:12
Gabez0r
Gabez0r reviewed Nov 3, 2020
View reviewed changes
storybook/src/elements/nuxeo-directory-radio-group/nuxeo-directory-radio-group.stories.js Outdated Show resolved Hide resolved
ui/nuxeo-data-table/data-table-row.js Outdated Show resolved Hide resolved
ui/nuxeo-data-table/data-table-row.js Outdated Show resolved Hide resolved
ui/nuxeo-data-table/default-styles.js Outdated Show resolved Hide resolved
ui/nuxeo-user-group-management/nuxeo-create-group.js Outdated Show resolved Hide resolved
ui/widgets/nuxeo-card.js Outdated Show resolved Hide resolved
ui/widgets/nuxeo-card.js Outdated Show resolved Hide resolved
@semisse semisse force-pushed the imp-ELEMENTS-1226-verticalAlignmentConsistencyWithNewTypography branch 7 times, most recently from 4cc8683 to 124b05f Compare November 5, 2020 11:09
@semisse semisse requested a review from Gabez0r November 5, 2020 11:13
@nuxeo-web-ui-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-elements-pr-305 here

Gabez0r
Gabez0r reviewed Nov 6, 2020
View reviewed changes
Copy link
Collaborator

@Gabez0r Gabez0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor misalignment between selectivity multi and single-valued
image, but I can live with it.

storybook/src/elements/widgets/widget.stories.js Outdated Show resolved Hide resolved
@semisse semisse force-pushed the imp-ELEMENTS-1226-verticalAlignmentConsistencyWithNewTypography branch from 124b05f to a1bf0e9 Compare November 6, 2020 18:45
@nuxeo-web-ui-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-elements-pr-305 here

mnixo
mnixo previously approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@mnixo mnixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

storybook/.storybook/nuxeo-demo-theme.js Show resolved Hide resolved
ui/widgets/nuxeo-date-picker.js Show resolved Hide resolved
@nuxeo-web-ui-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-elements-pr-305 here

richardsd
richardsd previously approved these changes Nov 10, 2020
View reviewed changes
@semisse
Copy link
Collaborator Author

semisse commented Nov 10, 2020

LGTM. Minor misalignment between selectivity multi and single-valued
image, but I can live with it.

We will let this improvement for the next topic which will include labels, placeholders, and states consistency.

@semisse semisse force-pushed the imp-ELEMENTS-1226-verticalAlignmentConsistencyWithNewTypography branch from ea4c722 to f42b83b Compare November 10, 2020 12:39
richardsd
richardsd previously approved these changes Nov 17, 2020
View reviewed changes
Gabez0r
Gabez0r reviewed Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@Gabez0r Gabez0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we forgot nuxeo-video-info and nuxeo-video-conversions. Both are missing --nuxeo-label and the latter also still uses an h3. It it's too much work, I'm ok with creating a bug ticket for this.

@semisse
ELEMENTS-1154: align with new typography guidelines
da87fea
@semisse
ELEMENTS-1240: ensure height of 52px in nuxeo-input
c78cea9
@semisse
ELEMENTS-1240: add nuxeo-input to storybook
725b047
@semisse
ELEMENTS-1226: add widgets story to storybook
49a2845
@semisse
ELEMENTS-1239: ensure height of 52px in nuxeo-textarea
327f1f1
@semisse
ELEMENTS-1227: ensure height of 52px and add new font no date-picker
7b9374d
@semisse
ELEMENTS-1227: add nuxeo-date-picker to widgets story in storybook
662fbdf
@semisse
ELEMENTS-1227: cleanup obsolete styles on nuxeo-date-picker
bf4db57
@semisse
ELEMENTS-1236: ensure height of 52px in nuxeo-selectivity
00c4bdf
@semisse
ELEMENTS-1236: add nuxeo-selectivity to storybook
259707d
@semisse
ELEMENTS-1236: replace caret italic tag with span
2f486bb
@semisse
ELEMENTS-1236: fix placeholder set on nuxeo-selectivity
b75fa7a
@semisse
ELEMENTS-1238: ensure height of 52px in nuxeo-datatable rows
346bddf
@semisse
ELEMENTS-1238: align data-table-column-filter
126a070
@semisse
ELEMENTS-1237: ensure height of 52px and change padding of nuxeo-dire…
cba19fc 
…ctory-radio-group
@semisse
ELEMENTS-1237: add nuxeo-directory-radio-group to storybook
d2ac4e9
@semisse
ELEMENTS-1265: ensure height of 52px in nuxeo-select
c479cae
@semisse
ELEMENTS-1265: add nuxeo-select to storybook
f719f8f
@semisse
ELEMENTS-1272: add nuxeo-sort-select and nuxeo-user-suggestion to sto…
3dfcb14 
…rybook
@semisse semisse force-pushed the imp-ELEMENTS-1226-verticalAlignmentConsistencyWithNewTypography branch from 19767d5 to 3dfcb14 Compare November 17, 2020 12:07
@nuxeo-web-ui-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-elements-pr-305 here

@semisse semisse merged commit 375814b into master Nov 17, 2020
@semisse semisse deleted the imp-ELEMENTS-1226-verticalAlignmentConsistencyWithNewTypography branch November 17, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardsd richardsd richardsd approved these changes

@mnixo mnixo mnixo approved these changes

@nmpcunha nmpcunha Awaiting requested review from nmpcunha

@andreacornaglia andreacornaglia Awaiting requested review from andreacornaglia

@nelsonsilva nelsonsilva Awaiting requested review from nelsonsilva

@Gabez0r Gabez0r Awaiting requested review from Gabez0r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@semisse @nuxeojenkins @nuxeo-web-ui-jx-bot @richardsd @mnixo @Gabez0r