Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXP-29372: add more info to package view #15

Merged
merged 4 commits into from Aug 6, 2020

Conversation

atchertchian
Copy link
Member

@atchertchian atchertchian commented Aug 3, 2020

Creating draft PR waiting for additional changes and feedback on preview instance from product/support

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXP-29372: Improve packages webengine views on explorer

efge
efge previously approved these changes Aug 3, 2020
Copy link
Member

@efge efge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is probably not needed at this point, as the code has no intrinsic complexity or surprises

kevinleturc
kevinleturc previously approved these changes Aug 4, 2020
@atchertchian
Copy link
Member Author

Will rebase to avoid hitting random ftest issues

@atchertchian
Copy link
Member Author

Functional tests show that an error is visible in logs when the package references bundles not present in the distribution (can happen with partial distribs) --> will need to refine commits to avoid that

@atchertchian atchertchian force-pushed the feature-NXP-29372-packages-view branch 2 times, most recently from 8818ed8 to 6e96943 Compare August 5, 2020 10:59
@atchertchian atchertchian force-pushed the feature-NXP-29372-packages-view branch from 6e96943 to 5c5c4cd Compare August 5, 2020 12:43
@atchertchian atchertchian force-pushed the feature-NXP-29372-packages-view branch from 5c5c4cd to 0b4e20e Compare August 5, 2020 16:58
@atchertchian
Copy link
Member Author

Now that preview is visible, @tmartins seems happy with the changes.
Can i get reviews to be able to merge please? (will rebase #12 on master after that)

kevinleturc
kevinleturc previously approved these changes Aug 6, 2020
efge
efge previously approved these changes Aug 6, 2020
Copy link
Member

@efge efge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible improvement

@atchertchian atchertchian dismissed stale reviews from efge and kevinleturc via ec12457 August 6, 2020 16:21
@atchertchian atchertchian force-pushed the feature-NXP-29372-packages-view branch from 0b4e20e to ec12457 Compare August 6, 2020 16:21
@atchertchian atchertchian merged commit af0657f into master Aug 6, 2020
@atchertchian atchertchian deleted the feature-NXP-29372-packages-view branch August 6, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants