Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXBT-2399: split and version nuxeo packaging Jenkinsfile #3

Merged
merged 4 commits into from Dec 20, 2018

Conversation

alexistimic
Copy link
Contributor

No description provided.

@nuxeojenkins
Copy link

View issue in JIRA

Copy link
Contributor

@jcarsique jcarsique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a header to the file.
+1 beside the few remarks and improvements.

Jenkinsfile Outdated
[$class: 'ParametersDefinitionProperty', parameterDefinitions: [
[$class: 'StringParameterDefinition', defaultValue: '6.0-SNAPSHOT', description: 'Product version to build', name: 'NUXEO_VERSION'],
[$class: 'StringParameterDefinition', defaultValue: '', description: 'Optional - Use the
specified URL (eg a link to staging) as the source for the distribution instead of maven', name: 'DISTRIBUTION_URL'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reword DISTRIBUTION_URL description to:

Optional - Alternate URL to download the distribution from instead of the default Maven artifact download.
For instance: http://community.nuxeo.com/static/snapshots/nuxeo-server-tomcat-10.3-SNAPSHOT.zip

It seems there's a line return here :/

[$class: 'StringParameterDefinition', defaultValue: '6.0-SNAPSHOT', description: 'Product version to build', name: 'NUXEO_VERSION'],
[$class: 'StringParameterDefinition', defaultValue: '', description: 'Optional - Use the
specified URL (eg a link to staging) as the source for the distribution instead of maven', name: 'DISTRIBUTION_URL'],
[$class: 'BooleanParameterDefinition', defaultValue: true, description: 'Publish debian package', name: 'PUBLISH_DEB'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debian

Jenkinsfile Outdated
[$class: 'BooleanParameterDefinition', defaultValue: true, description: 'Publish debian package', name: 'PUBLISH_DEB'],
[$class: 'StringParameterDefinition', defaultValue: '/var/www/community.nuxeo.com/static/staging/', description: 'Staging publishing destination path (for scp)', name: 'STAGING_PATH'],
[$class: 'StringParameterDefinition', defaultValue: 'nuxeo@lethe.nuxeo.com', description: 'Publishing destination host (for scp)', name: 'DEPLOY_HOST']]],
pipelineTriggers([])])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Jenkinsfile Outdated
echo "*** "$(date +"%H:%M:%S")" Cloning/updating nuxeo-packaging-debian"
if [ ! -d nuxeo-packaging-debian ]; then
git clone git@github.com:nuxeo/nuxeo-packaging-debian.git
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@jcarsique
Copy link
Contributor

👍

@alexistimic alexistimic merged commit 7f50efc into master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants