NXBT-2399: split and version nuxeo packaging Jenkinsfile #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarsique
suggested changes
Sep 27, 2018
Jenkinsfile
Outdated
| [$class: 'RebuildSettings', autoRebuild: false, rebuildDisabled: false], | ||
| [$class: 'ParametersDefinitionProperty', parameterDefinitions: [ | ||
| [$class: 'StringParameterDefinition', defaultValue: '6.0-SNAPSHOT', description: 'Product version to build', name: 'NUXEO_VERSION'], | ||
| [$class: 'StringParameterDefinition', defaultValue: '', description: 'Optional - Use the specified URL (eg a link to staging) as the source for the distribution instead of maven', name: 'DISTRIBUTION_URL'], |
There was a problem hiding this comment.
Reword DISTRIBUTION_URL description to:
Optional - Alternate URL to download the distribution from instead of the default Maven artifact download.
For instance: http://community.nuxeo.com/static/snapshots/nuxeo-server-tomcat-10.3-SNAPSHOT.zip
Jenkinsfile
Outdated
| [$class: 'BooleanParameterDefinition', defaultValue: true, description: 'Publish .exe package', name: 'PUBLISH_EXE'], | ||
| [$class: 'StringParameterDefinition', defaultValue: '/var/www/community.nuxeo.com/static/staging/', description: 'Staging publishing destination path (for scp)', name: 'STAGING_PATH'], | ||
| [$class: 'StringParameterDefinition', defaultValue: 'nuxeo@lethe.nuxeo.com', description: 'Publishing destination host (for scp)', name: 'DEPLOY_HOST']]], | ||
| pipelineTriggers([])]) |
There was a problem hiding this comment.
what is the empty pipelineTriggers for?
Jenkinsfile
Outdated
| echo "*** "$(date +"%H:%M:%S")" Cloning/updating nuxeo-packaging-windows" | ||
| if [ ! -d nuxeo-packaging-windows ]; then | ||
| git clone git@github.com:nuxeo/nuxeo-packaging-windows.git | ||
| fi |
|
Add a header to the file. |
jcarsique
suggested changes
Oct 1, 2018
windows-installer.xml
Outdated
|
|
||
| <groupId>org.nuxeo.packaging</groupId> | ||
| <artifactId>windows-installer-3parties</artifactId> | ||
| <version>3.1</version> |
There was a problem hiding this comment.
Usage:
- under Continuous Integration: SNAPSHOT version
- on release: fixed version
=> 3.2-SNAPSHOT
windows-installer.xml
Outdated
| </unsubscribe> | ||
| <archive>http://lists.nuxeo.com/pipermail/nuxeo-dev/</archive> | ||
| </mailingList> | ||
| </mailingLists> |
There was a problem hiding this comment.
some deprecated URLs, either fix or don't mention (+JIRA ticket) ; see
windows-installer.xml
Outdated
|
|
||
| <issueManagement> | ||
| <system>jira</system> | ||
| <url>http://jira.nuxeo.com/browse/NXP</url> |
There was a problem hiding this comment.
windows-installer.xml
Outdated
|
|
||
| <ciManagement> | ||
| <system>Jenkins</system> | ||
| <url>http://qa.nuxeo.org/jenkins/</url> |
There was a problem hiding this comment.
link to the job is even better
windows-installer.xml
Outdated
| <excludes> | ||
| <exclude>org.nuxeo:nuxeo-ftest:1.8.6-SNAPSHOT:zip</exclude> | ||
| <!-- <exclude>org.jboss.seam:*</exclude> --> | ||
| </excludes> |
windows-installer.xml
Outdated
| </profile> | ||
|
|
||
| <profile> | ||
| <id>qapriv</id> |
There was a problem hiding this comment.
remove profile even if harmless
windows-installer.xml
Outdated
| </developers> | ||
|
|
||
| <scm> | ||
| <connection>scm:git:git://github.com/nuxeo/nuxeo.git</connection> |
There was a problem hiding this comment.
windows-installer.xml
Outdated
| <repository> | ||
| <id>public-releases</id> | ||
| <url> | ||
| http://mavenin.nuxeo.com/nexus/content/repositories/public-releases |
There was a problem hiding this comment.
deploy to vendor-releases
https://maven-eu.nuxeo.org/nexus/#view-repositories;vendor-releases~browsestorage
windows-installer.xml
Outdated
| <snapshotRepository> | ||
| <id>public-snapshots</id> | ||
| <url> | ||
| http://mavenin.nuxeo.com/nexus/content/repositories/public-snapshots |
There was a problem hiding this comment.
windows-installer.xml
Outdated
| <distributionManagement> | ||
| <site> | ||
| <id>maven-website</id> | ||
| <url>scpexe://gironde.nuxeo.com/home/mavenweb/site/</url> |
alexistimic
force-pushed
the
feature-NXBT-2399-split&fix
branch
3 times, most recently
from
acfa7e1
to
1ee1dc6
Compare
jcarsique
approved these changes
Nov 19, 2018
|
👍 |
alexistimic
force-pushed
the
feature-NXBT-2399-split&fix
branch
from
1ee1dc6
to
15ecfa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.