Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXPY-201: Allow more extensability of request_token() #233

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Apr 20, 2021

Also simplified the OAuth2Error exception as the stacktrace was not useful.

Also simplified the `OAuth2Error` exception as the stacktrace was not useful.
@nuxeojenkins
Copy link

View issue in JIRA: NXPY-201: Implement support for OAuth2

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 20, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.23%.

Quality metrics Before After Change
Complexity 1.12 ⭐ 1.12 ⭐ 0.00
Method Length 21.36 ⭐ 21.18 ⭐ -0.18 👍
Working memory 5.26 ⭐ 5.19 ⭐ -0.07 👍
Quality 89.46% 89.69% 0.23% 👍
Other metrics Before After Change
Lines 317 321 4
Changed files Quality Before Quality After Quality Change
nuxeo/exceptions.py 92.49% ⭐ 92.60% ⭐ 0.11% 👍
nuxeo/auth/oauth2.py 80.52% ⭐ 80.76% ⭐ 0.24% 👍
tests/test_exception.py 95.55% ⭐ 95.98% ⭐ 0.43% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nuxeo/auth/oauth2.py OAuth2.create_authorization_url 0 ⭐ 39 ⭐ 10 😞 78.27% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #233 (b45ba7b) into master (afec724) will not change coverage.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files          29       29           
  Lines        1782     1782           
=======================================
  Hits         1725     1725           
  Misses         57       57           
Flag Coverage Δ
unit 96.80% <71.42%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nuxeo/auth/oauth2.py 76.92% <50.00%> (ø)
nuxeo/exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afec724...b45ba7b. Read the comment docs.

@BoboTiG BoboTiG merged commit d5104ed into master Apr 20, 2021
@BoboTiG BoboTiG deleted the impr-NXPY-201-use-kwargs-request_token branch April 20, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants