NXPY-232: Allow specifying the upload provider type in the batch details (Sourcery refactored) #257
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report
@@ Coverage Diff @@
## impr-NXPY-232-provider-type #257 +/- ##
============================================================
Coverage 96.58% 96.58%
============================================================
Files 29 29
Lines 1788 1788
============================================================
Hits 1727 1727
Misses 61 61
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BoboTiG
force-pushed
the
impr-NXPY-232-provider-type
branch
from
6550022
to
0019d3f
Compare
sourcery-ai
bot
force-pushed
the
sourcery/impr-NXPY-232-provider-type
branch
from
9bcafcf
to
13d12af
Compare
| if handler in handlers: | ||
| if handler != "default": | ||
| endpoint = f"{endpoint}/new/{handler}" | ||
| else: | ||
| if handler not in handlers: | ||
| raise InvalidUploadHandler(handler, handlers) | ||
|
|
||
| if handler != "default": | ||
| endpoint = f"{endpoint}/new/{handler}" |
There was a problem hiding this comment.
Function API.post refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
| elif chunked: | ||
| from .handlers.default import ChunkUploader as cls | ||
| else: | ||
| if chunked: | ||
| from .handlers.default import ChunkUploader as cls | ||
| else: | ||
| from .handlers.default import Uploader as cls | ||
| from .handlers.default import Uploader as cls |
There was a problem hiding this comment.
Function API.get_uploader refactored with the following changes:
- Merge else clause's nested if statement into elif (
merge-else-if-into-elif)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.66%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #256 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
impr-NXPY-232-provider-typebranch, then run:Help us improve this pull request!