NXPY-238: Fix issue with Self signed certificates (Sourcery refactored)

[sourcery-ai]

Pull Request #263 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the wip-NXPY--Investigate-the-login-issue-with-SSL-and-without-legacy-authentication-check-i.e.-oauth2 branch, then run:

git fetch origin sourcery/wip-NXPY--Investigate-the-login-issue-with-SSL-and-without-legacy-authentication-check-i.e.-oauth2
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.13%.

Quality metrics	Before	After	Change
Complexity	3.95 ⭐	3.89 ⭐	-0.06 👍
Method Length	62.33 🙂	62.30 🙂	-0.03 👍
Working memory	6.21 🙂	6.17 ⭐	-0.04 👍
Quality	72.50% 🙂	72.63% 🙂	0.13% 👍

Other metrics	Before	After	Change
Lines	4592	4513	-79

Changed files	Quality Before	Quality After	Quality Change
nuxeo/client.py	60.30% 🙂	60.68% 🙂	0.38% 👍
nuxeo/comments.py	80.38% ⭐	80.60% ⭐	0.22% 👍
nuxeo/documents.py	80.52% ⭐	80.51% ⭐	-0.01% 👎
nuxeo/models.py	88.93% ⭐	89.04% ⭐	0.11% 👍
nuxeo/operations.py	50.78% 🙂	51.06% 🙂	0.28% 👍
nuxeo/uploads.py	66.55% 🙂	66.68% 🙂	0.13% 👍
nuxeo/utils.py	66.02% 🙂	65.82% 🙂	-0.20% 👎
tests/constants.py	95.67% ⭐	95.51% ⭐	-0.16% 👎
tests/test_batchupload.py	58.77% 🙂	58.77% 🙂	0.00%
tests/test_document.py	68.93% 🙂	68.91% 🙂	-0.02% 👎
tests/test_log_response.py	93.50% ⭐	93.41% ⭐	-0.09% 👎
tests/test_nuxeo.py	81.48% ⭐	81.47% ⭐	-0.01% 👎
tests/test_repository.py	83.41% ⭐	83.41% ⭐	0.00%
tests/manual/many_small_files.py	82.28% ⭐	82.25% ⭐	-0.03% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
nuxeo/client.py	NuxeoClient.request	18 🙂	347 ⛔	17 ⛔	25.53% 😞	Try splitting into smaller methods. Extract out complex expressions
nuxeo/operations.py	API.execute	12 🙂	253 ⛔	23 ⛔	29.83% 😞	Try splitting into smaller methods. Extract out complex expressions
nuxeo/operations.py	API.save_to_file	19 😞	202 😞	15 😞	33.20% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tests/test_batchupload.py	test_upload_several_callbacks	11 🙂	360 ⛔		37.01% 😞	Try splitting into smaller methods
tests/test_batchupload.py	test_idempotent_requests	11 🙂	346 ⛔		37.43% 😞	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Merging #264 (1b49366) into wip-NXPY--Investigate-the-login-issue-with-SSL-and-without-legacy-authentication-check-i.e.-oauth2 (89e25dd) will decrease coverage by 0.04%.
The diff coverage is 90.47%.

@@                                                          Coverage Diff                                                           @@
##           wip-NXPY--Investigate-the-login-issue-with-SSL-and-without-legacy-authentication-check-i.e.-oauth2     #264      +/-   ##
======================================================================================================================================
- Coverage                                                                                               94.48%   94.44%   -0.05%     
======================================================================================================================================
  Files                                                                                                      29       29              
  Lines                                                                                                    1939     1925      -14     
======================================================================================================================================
- Hits                                                                                                     1832     1818      -14     
  Misses                                                                                                    107      107              

Flag	Coverage Δ
unit	94.44% <90.47%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
nuxeo/documents.py	92.95% <0.00%> (ø)
nuxeo/client.py	98.40% <100.00%> (-0.02%)	⬇️
nuxeo/comments.py	92.10% <100.00%> (ø)
nuxeo/models.py	93.05% <100.00%> (ø)
nuxeo/operations.py	100.00% <100.00%> (ø)
nuxeo/uploads.py	92.19% <100.00%> (-0.11%)	⬇️
nuxeo/utils.py	97.35% <100.00%> (-0.11%)	⬇️
nuxeo/handlers/s3.py	92.68% <0.00%> (-0.06%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sourcery-ai]

Function test_fetch refactored with the following changes:

• Replace if statement with if expression [×2] (assign-if-exp)

[sourcery-ai]

Function test_operation refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload_several_callbacks refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_document_create_bytes_warning refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_document_move refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseAutomation.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextOk.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_check_params refactored with the following changes:

• Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)

This removes the following comments ( why? ):

# 'pageNo' type == int
# 'end' type == str
# unknown param
# 'pageSize' type == int
# 'file' type == str
# 'info' type == dict
# 'value' type == Sequence
# 'query' type == str
# 'validationMethod' type == str
# 'queryParams' type in [list, str]
# 'blockInheritance' type == boolean
# 'properties' type == dict
# 'target' type == list
# 'file' type in (Blob, str)
# 'queryParams' is also optional, None should be accepted
# 'value' type == str
# 'startPage', 'endPage' type == long

[sourcery-ai]

Function test_server_info_bad_response refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_server_version_bad_response_from_server_info refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch_acls refactored with the following changes:

• Use set when checking membership of a collection of literals (collection-into-set)

[sourcery-ai]

Function download_file refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.__init__ refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)
• Use named expression to simplify assignment and conditional (use-named-expression)
• Remove unnecessary call to keys() (remove-dict-keys)

[sourcery-ai]

Function NuxeoClient.query refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.request refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Use named expression to simplify assignment and conditional (use-named-expression)
• Swap if/else branches of if expression to remove negation (swap-if-expression)
• Remove unnecessary call to keys() (remove-dict-keys)

[sourcery-ai]

Function NuxeoClient._handle_error refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)

[sourcery-ai]

Function API.get refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)

[sourcery-ai]

Lines 5-5 refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_digester refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_execute refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch refactored with the following changes:

• Replace if statement with if expression [×2] (assign-if-exp)

[sourcery-ai]

Function test_operation refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload_several_callbacks refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_document_create_bytes_warning refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_document_move refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseAutomation.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextOk.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_check_params refactored with the following changes:

• Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)

This removes the following comments ( why? ):

# 'properties' type == dict
# 'blockInheritance' type == boolean
# 'file' type == str
# 'pageSize' type == int
# 'queryParams' type in [list, str]
# 'queryParams' is also optional, None should be accepted
# 'startPage', 'endPage' type == long
# 'pageNo' type == int
# 'target' type == list
# 'value' type == Sequence
# 'validationMethod' type == str
# 'file' type in (Blob, str)
# 'value' type == str
# 'end' type == str
# unknown param
# 'info' type == dict
# 'query' type == str

[sourcery-ai]

Function test_server_info_bad_response refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_server_version_bad_response_from_server_info refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch_acls refactored with the following changes:

• Use set when checking membership of a collection of literals (collection-into-set)

[sourcery-ai]

Function download_file refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.__init__ refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)
• Use named expression to simplify assignment and conditional (use-named-expression)
• Remove unnecessary call to keys() (remove-dict-keys)

[sourcery-ai]

Function NuxeoClient.query refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.request refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Use named expression to simplify assignment and conditional (use-named-expression)
• Swap if/else branches of if expression to remove negation (swap-if-expression)
• Remove unnecessary call to keys() (remove-dict-keys)

[sourcery-ai]

Function NuxeoClient._handle_error refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)

[sourcery-ai]

Function API.get refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)

[sourcery-ai]

Lines 5-5 refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_digester refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_execute refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch refactored with the following changes:

• Replace if statement with if expression [×2] (assign-if-exp)

[sourcery-ai]

Function test_operation refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload_several_callbacks refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_document_create_bytes_warning refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_document_move refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseAutomation.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextOk.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_check_params refactored with the following changes:

• Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)

This removes the following comments ( why? ):

# 'blockInheritance' type == boolean
# 'end' type == str
# 'file' type in (Blob, str)
# 'pageSize' type == int
# 'info' type == dict
# 'file' type == str
# 'target' type == list
# 'validationMethod' type == str
# 'value' type == Sequence
# 'value' type == str
# 'startPage', 'endPage' type == long
# 'properties' type == dict
# 'queryParams' type in [list, str]
# 'pageNo' type == int
# unknown param
# 'queryParams' is also optional, None should be accepted
# 'query' type == str

[sourcery-ai]

Function test_server_info_bad_response refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_server_version_bad_response_from_server_info refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch_acls refactored with the following changes:

• Use set when checking membership of a collection of literals (collection-into-set)

[sourcery-ai]

Function download_file refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.__init__ refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)
• Use named expression to simplify assignment and conditional (use-named-expression)
• Remove unnecessary call to keys() (remove-dict-keys)

[sourcery-ai]

Function NuxeoClient.query refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.request refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Use named expression to simplify assignment and conditional (use-named-expression)
• Swap if/else branches of if expression to remove negation (swap-if-expression)
• Remove unnecessary call to keys() (remove-dict-keys)

[sourcery-ai]

Function NuxeoClient._handle_error refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)

[sourcery-ai]

Function API.get refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)

[sourcery-ai]

Lines 5-5 refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_digester refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_execute refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch refactored with the following changes:

• Replace if statement with if expression [×2] (assign-if-exp)

[sourcery-ai]

Function test_operation refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload_several_callbacks refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_document_create_bytes_warning refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_document_move refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseAutomation.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextOk.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_check_params refactored with the following changes:

• Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)

This removes the following comments ( why? ):

# 'queryParams' is also optional, None should be accepted
# unknown param
# 'end' type == str
# 'blockInheritance' type == boolean
# 'queryParams' type in [list, str]
# 'value' type == str
# 'pageSize' type == int
# 'file' type == str
# 'target' type == list
# 'query' type == str
# 'properties' type == dict
# 'startPage', 'endPage' type == long
# 'value' type == Sequence
# 'file' type in (Blob, str)
# 'info' type == dict
# 'validationMethod' type == str
# 'pageNo' type == int

[sourcery-ai]

Function test_server_info_bad_response refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_server_version_bad_response_from_server_info refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch_acls refactored with the following changes:

• Use set when checking membership of a collection of literals (collection-into-set)

[sourcery-ai]

Function download_file refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)