wip-NXPY-239: fix tests cases on python (Sourcery refactored)

[sourcery-ai]

Pull Request #271 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the wip-NXPY-239-Fix-tests-cases-on-Python branch, then run:

git fetch origin sourcery/wip-NXPY-239-Fix-tests-cases-on-Python
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.08%.

Quality metrics	Before	After	Change
Complexity	2.26 ⭐	2.23 ⭐	-0.03 👍
Method Length	51.89 ⭐	51.91 ⭐	0.02 👎
Working memory	5.19 ⭐	5.17 ⭐	-0.02 👍
Quality	77.25% ⭐	77.33% ⭐	0.08% 👍

Other metrics	Before	After	Change
Lines	3177	3171	-6

Changed files	Quality Before	Quality After	Quality Change
nuxeo/client.py	64.45% 🙂	64.82% 🙂	0.37% 👍
nuxeo/documents.py	82.51% ⭐	82.49% ⭐	-0.02% 👎
nuxeo/models.py	92.31% ⭐	92.44% ⭐	0.13% 👍
nuxeo/utils.py	66.49% 🙂	66.30% 🙂	-0.19% 👎
nuxeo/handlers/s3.py	71.91% 🙂	71.92% 🙂	0.01% 👍
tests/constants.py	96.17% ⭐	96.01% ⭐	-0.16% 👎
tests/test_batchupload.py	66.70% 🙂	66.65% 🙂	-0.05% 👎
tests/test_log_response.py	93.50% ⭐	93.41% ⭐	-0.09% 👎
tests/test_repository.py	83.56% ⭐	83.56% ⭐	0.00%
tests/manual/many_small_files.py	82.28% ⭐	82.25% ⭐	-0.03% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
nuxeo/client.py	NuxeoClient.request	14 🙂	307 ⛔	16 ⛔	30.76% 😞	Try splitting into smaller methods. Extract out complex expressions
nuxeo/utils.py	version_compare	16 🙂	226 ⛔	10 😞	41.75% 😞	Try splitting into smaller methods. Extract out complex expressions
tests/test_batchupload.py	test_upload_several_callbacks	5 ⭐	317 ⛔		46.99% 😞	Try splitting into smaller methods
tests/test_batchupload.py	test_idempotent_requests	5 ⭐	300 ⛔		47.77% 😞	Try splitting into smaller methods
nuxeo/utils.py	log_response	10 🙂	163 😞	12 😞	48.26% 😞	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Base: 96.30% // Head: 96.30% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (28fb109) compared to base (1866b4d).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files

@@                            Coverage Diff                             @@
##           wip-NXPY-239-Fix-tests-cases-on-Python     #272      +/-   ##
==========================================================================
- Coverage                                   96.30%   96.30%   -0.01%     
==========================================================================
  Files                                          26       26              
  Lines                                        1624     1622       -2     
==========================================================================
- Hits                                         1564     1562       -2     
  Misses                                         60       60              

Flag	Coverage Δ
unit	96.30% <83.33%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
nuxeo/documents.py	93.60% <0.00%> (ø)
nuxeo/client.py	99.43% <100.00%> (-0.01%)	⬇️
nuxeo/handlers/s3.py	92.68% <100.00%> (ø)
nuxeo/models.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sourcery-ai]

Function test_digester refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_execute refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_operation refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload_several_callbacks refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseAutomation.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContentsTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseCmis.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseEmpty.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextError.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextOk.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch_acls refactored with the following changes:

• Use set when checking membership of a collection of literals (collection-into-set)

[sourcery-ai]

Function download_file refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.__init__ refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)
• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.query refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.request refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)
• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Swap if/else branches of if expression to remove negation (swap-if-expression)

[sourcery-ai]

Function NuxeoClient._handle_error refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)

[sourcery-ai]

Function API.convert refactored with the following changes:

• Remove redundant conditional (remove-redundant-if)
• Remove unreachable code (remove-unreachable-code)
• Simplify if expression by using or (or-if-exp-identity)

[sourcery-ai]

Function test_execute refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_operation refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload_several_callbacks refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseAutomation.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContentsTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseCmis.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseEmpty.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextError.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextOk.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch_acls refactored with the following changes:

• Use set when checking membership of a collection of literals (collection-into-set)

[sourcery-ai]

Function download_file refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.__init__ refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)
• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.query refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.request refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)
• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Swap if/else branches of if expression to remove negation (swap-if-expression)

[sourcery-ai]

Function NuxeoClient._handle_error refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)

[sourcery-ai]

Function API.convert refactored with the following changes:

• Remove redundant conditional (remove-redundant-if)
• Remove unreachable code (remove-unreachable-code)

[sourcery-ai]

Function test_digester refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_execute refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_operation refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload_several_callbacks refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseAutomation.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContentsTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseCmis.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextError.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextOk.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch_acls refactored with the following changes:

• Use set when checking membership of a collection of literals (collection-into-set)

[sourcery-ai]

Function download_file refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.__init__ refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)
• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.query refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.request refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)
• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Swap if/else branches of if expression to remove negation (swap-if-expression)

[sourcery-ai]

Function NuxeoClient._handle_error refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)

[sourcery-ai]

Function API.trash refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload_several_callbacks refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseAutomation.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContentsTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseCmis.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseEmpty.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseError409.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseIso.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextError.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextOk.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch_acls refactored with the following changes:

• Use set when checking membership of a collection of literals (collection-into-set)

[sourcery-ai]

Function download_file refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.__init__ refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)
• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.query refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.request refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)
• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Swap if/else branches of if expression to remove negation (swap-if-expression)

[sourcery-ai]

Function NuxeoClient._handle_error refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)

[sourcery-ai]

Function API.trash refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload_several_callbacks refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseAutomation.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContentsTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseCmis.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseEmpty.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseError409.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseIso.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextError.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextOk.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch_acls refactored with the following changes:

• Use set when checking membership of a collection of literals (collection-into-set)

[sourcery-ai]

Function download_file refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.__init__ refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)
• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.query refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function NuxeoClient.request refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)
• Merge dictionary updates via the union operator (dict-assign-update-to-union)
• Swap if/else branches of if expression to remove negation (swap-if-expression)

[sourcery-ai]

Function NuxeoClient._handle_error refactored with the following changes:

• Merge dictionary updates via the union operator (dict-assign-update-to-union)

[sourcery-ai]

Function API.trash refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function test_upload_several_callbacks refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseAutomation.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContents.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseChunkedJsonContentsTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseCmis.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseEmpty.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseError409.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseIso.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextError.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextOk.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function ResponseTextTooLong.__init__ refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function test_fetch_acls refactored with the following changes:

• Use set when checking membership of a collection of literals (collection-into-set)

[sourcery-ai]

Function download_file refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)