Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXPY-253: Restore capability to use the client with a local HTTP server #300

Conversation

gitofanindya
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (a7a95a0) to head (7e3bff1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
- Coverage   96.63%   96.63%   -0.01%     
==========================================
  Files          29       29              
  Lines        1813     1811       -2     
==========================================
- Hits         1752     1750       -2     
  Misses         61       61              
Flag Coverage Δ
functional 90.00% <100.00%> (-0.02%) ⬇️
unit 51.57% <71.42%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mr-shekhar mr-shekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests needs to be updated.

@gitofanindya gitofanindya force-pushed the wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server branch 15 times, most recently from 249e8ac to 770a86d Compare February 22, 2024 13:33
@gitofanindya gitofanindya force-pushed the wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server branch from 770a86d to 0e33e97 Compare February 22, 2024 13:42
@gitofanindya gitofanindya force-pushed the wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server branch from ee27ef8 to c744d62 Compare February 27, 2024 06:35
@gitofanindya gitofanindya force-pushed the wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server branch 2 times, most recently from 5d86067 to bbe70bb Compare February 27, 2024 07:45
@gitofanindya gitofanindya force-pushed the wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server branch from bbe70bb to 7e3bff1 Compare February 27, 2024 07:48
Copy link
Collaborator

@mr-shekhar mr-shekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gitofanindya gitofanindya merged commit 54400d7 into master Feb 27, 2024
8 checks passed
@gitofanindya gitofanindya deleted the wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server branch February 27, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants