-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXPY-255: Fix Test cases for moto3 #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Bug fix
PR Summary: This pull request addresses the update of testing dependencies and the corresponding changes required in the test cases to ensure compatibility with the latest versions. Specifically, it updates the usage of the 'moto' library for mocking AWS services in the S3 upload functionality tests.
Decision: Comment
📝 Type: 'Bug fix' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that all tests pass with the updated 'moto' library version to confirm that the changes do not introduce any regressions.
- Consider adding a brief description in the PR about why the change from 'mock_s3' to 'mock_aws' was necessary. This could help in understanding the context of the change and its impact on the test cases.
- Review other test cases that might be affected by the update in the 'moto' library to ensure consistency across the project.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #303 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 29 29
Lines 1813 1813
=======================================
Hits 1752 1752
Misses 61 61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pl describe the reason for change. |
Previously, we imported'mock_s3' from moto to mock the S3 during upload testing. However, since we recently upgraded Moto to v5.x.x, all of the decorators have been replaced with a single decorator -'mock_aws'. So we've replaced "mock_s3" with "mock_aws". Reference: https://github.com/getmoto/moto/blob/master/CHANGELOG.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pl add detail
No description provided.