Release fix: Upload nuxeo-python-client to packages #311
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @swetayadav1 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| with: | ||
| python-version: 3.9 | ||
| - run: python -m pip install -U pip setuptools wheel | ||
| - run: python setup.py bdist_wheel |
There was a problem hiding this comment.
suggestion (code_refinement): Consider using build backend for building wheels.
Using modern build backends like 'build' or 'pep517' can provide better isolation and configuration management compared to 'setup.py'.
| - run: python setup.py bdist_wheel | |
| - run: python -m pip install build | |
| - run: python -m build --wheel |
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: 3.9 | ||
| - run: python setup.py sdist |
There was a problem hiding this comment.
suggestion (code_refinement): Consider using modern tools for source distribution.
Similar to wheel building, using 'build' or 'pep517' for source distribution can enhance the build process.
| - run: python setup.py sdist | |
| - run: pip install build | |
| - run: python -m build --sdist |
| with: | ||
| name: python-package-distributions | ||
| path: dist/ | ||
| - run: ls -l dist |
There was a problem hiding this comment.
suggestion (code_refinement): Consider removing or commenting the purpose of the 'ls' command.
If the 'ls -l dist' command is for debugging, it might be better to either remove it for cleaner CI logs or comment its purpose for clarity.
| - run: ls -l dist | |
| # The following command lists the contents of the 'dist' directory to verify the build artifacts: | |
| - run: ls -l dist |
| python-version: 3.9 | ||
|
|
||
| - name: Install twine | ||
| run: python -m pip install twine |
There was a problem hiding this comment.
suggestion (code_refinement): Consider pinning the version of 'twine' to avoid potential future compatibility issues.
Pinning the version can ensure consistent behavior across different runs and avoid unexpected breaks due to package updates.
| run: python -m pip install twine | |
| run: python -m pip install twine==3.8.0 |
No description provided.