Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXP-29026: fix the CSV export retention action #8

Merged
merged 1 commit into from Nov 19, 2020
Merged

NXP-29026: fix the CSV export retention action #8

merged 1 commit into from Nov 19, 2020

Conversation

RSalem07
Copy link
Contributor

No description provided.

@nuxeojenkins
Copy link

View issue in JIRA: NXP-29026: Fix Export CSV Action in Retention Search page

nmpcunha
nmpcunha approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@nmpcunha nmpcunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the comment on the styling removal, it looks good to me 👍🏼
Guess it will be easier to validate the styling question with the preview (WIP)

@RSalem07 RSalem07 force-pushed the fix-NXP-29026-Export-CSV-Action-in-Retention-Search-page branch from 566ea76 to c37c8ee Compare November 19, 2020 08:26
@nmpcunha
Copy link
Contributor

LGTM 👍🏼

@RSalem07 RSalem07 merged commit 33c77ff into master Nov 19, 2020
@RSalem07 RSalem07 mentioned this pull request Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreacornaglia andreacornaglia andreacornaglia approved these changes

@nmpcunha nmpcunha nmpcunha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@RSalem07 @nuxeojenkins @nmpcunha @andreacornaglia