Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(backport) Imp elements 1212 nuxeo data table colum always visible #489

Merged
merged 1 commit into from Aug 17, 2020
Merged

(backport) Imp elements 1212 nuxeo data table colum always visible #489

merged 1 commit into from Aug 17, 2020

Conversation

andreacornaglia
Copy link

No description provided.

@nuxeojenkins
Copy link
Contributor

View issues in JIRA:

  • ELEMENTS-121: Data-table-settings > Make settings button relative to the table
  • ELEMENTS-1212: Allow table columns to be always visible - not editable on settings modal

@andreacornaglia andreacornaglia force-pushed the imp-ELEMENTS-1212-nuxeoDataTableColumAlwaysVisible branch 4 times, most recently from 017c674 to 9a92332 Compare August 11, 2020 09:00
@andreacornaglia andreacornaglia force-pushed the imp-ELEMENTS-1212-nuxeoDataTableColumAlwaysVisible branch from 9a92332 to f0141d6 Compare August 13, 2020 12:32
Gabez0r
Gabez0r previously approved these changes Aug 13, 2020
View reviewed changes
nmpcunha
nmpcunha approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@nmpcunha nmpcunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Please make sure UI team (cc @Gabez0r ) is happy with the commit message. AFAIK, we (and they) don't use to have backport on it, using the same as on master branch.

nmpcunha
nmpcunha suggested changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@nmpcunha nmpcunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, as per Backport Policies we must keep the same message (for tracking purposes)

@Gabez0r
Copy link
Collaborator

Gabez0r commented Aug 13, 2020

Indeed, "backport" is not adding anything to it. We usually use the same message. The exception is when we are backporting using a separate ticket, where we may add "backport of ..." for clarity. (see example).

@andreacornaglia andreacornaglia force-pushed the imp-ELEMENTS-1212-nuxeoDataTableColumAlwaysVisible branch from f0141d6 to 2066416 Compare August 13, 2020 14:10
@andreacornaglia andreacornaglia merged commit 61ee4ec into maintenance-2.4.x Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabez0r Gabez0r Gabez0r approved these changes

@nmpcunha nmpcunha nmpcunha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@andreacornaglia @nuxeojenkins @Gabez0r @nmpcunha