Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELEMENTS-1275: selectivity dropdown close 10.10 #511

Merged
merged 2 commits into from Nov 19, 2020
Merged

ELEMENTS-1275: selectivity dropdown close 10.10 #511

merged 2 commits into from Nov 19, 2020

Conversation

richardsd
Copy link
Contributor

Backport of the nuxeo/nuxeo-elements#312

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: ELEMENTS-1275: Fix selectivity dropdowns when opened in forms

@richardsd
Copy link
Contributor Author

richardsd commented Nov 16, 2020 •
edited

Pipeline at https://qa2.nuxeo.org/jenkins/job/WebUI/job/web-ui-pipeline-10.10/640/ 🔵

@richardsd richardsd force-pushed the fix-ELEMENTS-1275-selectivity-dropdown-close-10.10 branch from 03b4afb to 14829c9 Compare November 16, 2020 16:59
mnixo
mnixo previously approved these changes Nov 17, 2020
View reviewed changes
widgets/nuxeo-selectivity.html Outdated Show resolved Hide resolved
@richardsd
ELEMENTS-1275: update dropdown position upon parent scrolling events
5955db7 
Close the dropdown when selectivity is outside the viewport.
@richardsd richardsd force-pushed the fix-ELEMENTS-1275-selectivity-dropdown-close-10.10 branch from 836a5ec to 5955db7 Compare November 18, 2020 10:00
@richardsd richardsd requested a review from mnixo November 18, 2020 10:00
Gabez0r
Gabez0r approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@Gabez0r Gabez0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please run it through the pipeline if you haven't yet after the force push.

@richardsd
Copy link
Contributor Author

Pipeline 🔵 https://qa2.nuxeo.org/jenkins/job/WebUI/job/web-ui-pipeline-10.10/640/

@richardsd richardsd merged commit e67ed02 into maintenance-2.4.x Nov 19, 2020
@richardsd richardsd deleted the fix-ELEMENTS-1275-selectivity-dropdown-close-10.10 branch November 19, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnixo mnixo mnixo approved these changes

@Gabez0r Gabez0r Gabez0r approved these changes

@semisse semisse Awaiting requested review from semisse

@nelsonsilva nelsonsilva Awaiting requested review from nelsonsilva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@richardsd @nuxeojenkins @mnixo @Gabez0r