Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEBUI-159: check missing items on nuxeo-data-grid and fetch them (Backport 10.10) #515

Merged
merged 1 commit into from Jan 7, 2021
Merged

WEBUI-159: check missing items on nuxeo-data-grid and fetch them (Backport 10.10) #515

merged 1 commit into from Jan 7, 2021

Conversation

semisse
Copy link
Collaborator

@semisse semisse commented Dec 21, 2020

No description provided.

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: WEBUI-159: Fix loading of thumbnail in high-resolution grid view

mnixo
mnixo previously approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@mnixo mnixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that we don't need this observer here as well?

richardsd
richardsd previously approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@richardsd richardsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not forget mnixo comment about the observer.

@semisse
Copy link
Collaborator Author

semisse commented Dec 29, 2020

Are we sure that we don't need this observer here as well?

You are 100% right.

@semisse semisse dismissed stale reviews from richardsd and mnixo via 354e578 December 29, 2020 11:58
@semisse semisse force-pushed the fix-WEBUI-159-fetchMissingItemsNuxeoDataGrid-10.10 branch from 4c352ad to 354e578 Compare December 29, 2020 11:58
@semisse semisse requested a review from Gabez0r January 4, 2021 13:55
@semisse semisse mentioned this pull request Jan 7, 2021
Closed
@semisse semisse merged commit 1b1464c into maintenance-2.4.x Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardsd richardsd richardsd approved these changes

@mnixo mnixo mnixo approved these changes

@nelsonsilva nelsonsilva Awaiting requested review from nelsonsilva

@Gabez0r Gabez0r Awaiting requested review from Gabez0r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@semisse @nuxeojenkins @richardsd @mnixo