Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELEMENTS-1362: remove dots and underscores from http headers #535

Merged
merged 1 commit into from May 6, 2021
Merged

ELEMENTS-1362: remove dots and underscores from http headers #535

merged 1 commit into from May 6, 2021

Conversation

richardsd
Copy link
Contributor

@richardsd richardsd commented May 5, 2021 •
edited

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: ELEMENTS-1362: Don't use dots or underscores in custom HTTP headers

Gabez0r
Gabez0r approved these changes May 5, 2021
View reviewed changes
Copy link
Collaborator

@Gabez0r Gabez0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please run the pipeline before merging.

@richardsd richardsd merged commit d704ad5 into maintenance-2.4.x May 6, 2021
@richardsd richardsd deleted the ELEMENTS-1362-http-headers branch May 6, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonsilva nelsonsilva nelsonsilva approved these changes

@mnixo mnixo mnixo approved these changes

@Gabez0r Gabez0r Gabez0r approved these changes

@semisse semisse Awaiting requested review from semisse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@richardsd @nuxeojenkins @nelsonsilva @mnixo @Gabez0r