NXP-29867: make EventServiceImpl#fireEvent do not throw RuntimeException #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View issue in JIRA: NXP-29867: Fix custom HTTP code thrown by event listener being ignored when DnD'ing a file in a folder in the Web UI |
efge
requested changes
Jan 5, 2021
modules/core/nuxeo-core-event/src/test/java/org/nuxeo/ecm/core/event/test/RollbackListener.java
Outdated
Show resolved
Hide resolved
modules/core/nuxeo-core-event/src/main/java/org/nuxeo/ecm/core/event/impl/EventServiceImpl.java
Outdated
Show resolved
Hide resolved
.../nuxeo-core-event/src/test/java/org/nuxeo/ecm/core/event/test/TestEventServiceComponent.java
Show resolved
Hide resolved
ataillefer
reviewed
Jan 6, 2021
modules/core/nuxeo-core-event/src/test/resources/test-rollback-listener.xml
Show resolved
Hide resolved
Do not throw a RuntimeException anymore: - if it's already a NuxeoException, rethrow it - otherwise wrap the exception in a NuxeoException
troger
force-pushed
the
fix-NXP-29867-http-code-error-automation
branch
from
ec6b576
to
baae2fe
Compare
efge
approved these changes
Jan 6, 2021
ataillefer
reviewed
Jan 6, 2021
.../nuxeo-core-event/src/test/java/org/nuxeo/ecm/core/event/test/TestEventServiceComponent.java
Show resolved
Hide resolved
.../nuxeo-core-event/src/test/java/org/nuxeo/ecm/core/event/test/TestEventServiceComponent.java
Show resolved
Hide resolved
ataillefer
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not throw a RuntimeException anymore: