NXP-30463: Fix Azure storage tests + fix Azure GC + add concurrent image upload test #4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efge
reviewed
Jul 7, 2021
...o-core-binarymanager-cloud/nuxeo-core-binarymanager-azure/src/test/resources/log4j2-test.xml
Show resolved
Hide resolved
Not really, a certain size is required for the error to appear with the old lib version, I'd prefer to leave it. |
kevinleturc
previously approved these changes
Jul 7, 2021
...o-core-binarymanager-azure/src/main/java/org/nuxeo/ecm/blob/azure/AzureGarbageCollector.java
Outdated
Show resolved
Hide resolved
ataillefer
force-pushed
the
fix-NXP-30463-azure-specified-block-list-is-invalid
branch
from
75d7214
to
e137ae3
Compare
kevinleturc
previously approved these changes
Jul 7, 2021
ataillefer
force-pushed
the
fix-NXP-30463-azure-specified-block-list-is-invalid
branch
from
e137ae3
to
b9cc7d3
Compare
As done for S3 with https://jira.nuxeo.com/browse/NXP-30412. This fixes `TestAzureBinaryManager#testBinaryManagerGCWithConcurrentCreation`.
ataillefer
force-pushed
the
fix-NXP-30463-azure-specified-block-list-is-invalid
branch
from
b9cc7d3
to
1c03c4b
Compare
kevinleturc
approved these changes
Jul 7, 2021
efge
approved these changes
Jul 7, 2021
ataillefer
deleted the
fix-NXP-30463-azure-specified-block-list-is-invalid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug described in NXP-30463 only happens in 10.10, with an old version of the
azure-storagelibrary.Yet, this PR updates/cleans up/fixes the existing tests and adds a test for concurrent image upload (NXP-30463).